Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_peer: Remove duplicate 'profile' parameter, it's automatically added by ec2_argument_spec #171

Merged
merged 1 commit into from
Aug 1, 2020

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 31, 2020

SUMMARY

After adding an extra alias (over in amazon.aws) we're triggering a sanity test failure because:

plugins/modules/ec2_vpc_peer.py:0:0: nonexistent-parameter-documented: Argument 'aws_profile' is listed in DOCUMENTATION.options, but not accepted by the module argument_spec

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

e2c_vpc_peer

ADDITIONAL INFORMATION

https://app.shippable.com/github/ansible-collections/community.aws/runs/511/2/tests

@tremble
Copy link
Contributor Author

tremble commented Aug 1, 2020

Minor fix, tests pass, approved by @jillr, merging.

@tremble tremble merged commit 8d6b652 into ansible-collections:main Aug 1, 2020
@tremble tremble deleted the sanity/vpc_peer_profile branch February 11, 2021 09:27
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 16, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request Jul 19, 2021
alinabuzachis pushed a commit to alinabuzachis/community.aws that referenced this pull request May 25, 2022
…s#171)

* Provide support for AWS S3 Public Access Blocking
* Documentation
* Execute get_bucket_public_access only if required
* changelog
* Add missing version_added entries to doc

Resolves issue ansible-collections#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants