Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing parameter name in example. #1092

Conversation

psharkey
Copy link
Contributor

SUMMARY

Fixing parameter used in example.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

aws_acm

ADDITIONAL INFORMATION

Using the example as is gives in an error -

fatal: [localhost]: FAILED! => changed=false 
  msg: 'state is present but all of the following are missing: private_key'

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review docs module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Apr 25, 2022
@matt-telstra
Copy link

Looks good to me

@markuman markuman added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Apr 26, 2022
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're right. Thanks for catching this.

    argument_spec = dict(
        certificate=dict(),
        certificate_arn=dict(aliases=['arn']),
        certificate_chain=dict(),
        domain_name=dict(aliases=['domain']),
        name_tag=dict(aliases=['name']),
        private_key=dict(no_log=True),
        tags=dict(type='dict'),
        purge_tags=dict(type='bool', default=False),
        state=dict(default='present', choices=['present', 'absent']),
    )

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 26, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 2ea42db into ansible-collections:main Apr 26, 2022
@patchback
Copy link

patchback bot commented Apr 26, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/2ea42db329b94c5f79c1390970278a3b645a829b/pr-1092

Backported as #1094

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 26, 2022
Fixing parameter name in example.

SUMMARY
Fixing parameter used in example.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
aws_acm
ADDITIONAL INFORMATION
Using the example as is gives in an error -
fatal: [localhost]: FAILED! => changed=false
  msg: 'state is present but all of the following are missing: private_key'

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 2ea42db)
@patchback
Copy link

patchback bot commented Apr 26, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/2ea42db329b94c5f79c1390970278a3b645a829b/pr-1092

Backported as #1095

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 26, 2022
Fixing parameter name in example.

SUMMARY
Fixing parameter used in example.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
aws_acm
ADDITIONAL INFORMATION
Using the example as is gives in an error -
fatal: [localhost]: FAILED! => changed=false
  msg: 'state is present but all of the following are missing: private_key'

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Mark Chappell <None>
(cherry picked from commit 2ea42db)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 26, 2022
[PR #1092/2ea42db3 backport][stable-3] Fixing parameter name in example.

This is a backport of PR #1092 as merged into main (2ea42db).
SUMMARY
Fixing parameter used in example.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
aws_acm
ADDITIONAL INFORMATION
Using the example as is gives in an error -
fatal: [localhost]: FAILED! => changed=false 
  msg: 'state is present but all of the following are missing: private_key'

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 26, 2022
[PR #1092/2ea42db3 backport][stable-2] Fixing parameter name in example.

This is a backport of PR #1092 as merged into main (2ea42db).
SUMMARY
Fixing parameter used in example.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
aws_acm
ADDITIONAL INFORMATION
Using the example as is gives in an error -
fatal: [localhost]: FAILED! => changed=false 
  msg: 'state is present but all of the following are missing: private_key'

Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch community_review docs mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants