Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure static website on storage account #878

Merged
merged 18 commits into from
Jun 14, 2022
Merged

Configure static website on storage account #878

merged 18 commits into from
Jun 14, 2022
+324 −25

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Jun 11, 2022

SUMMARY

This PR adds the ability to configure the static website feature of a blob storage account.

image

Fixes #459.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/modules/azure_rm_storageaccount.py
plugins/modules/azure_rm_storageaccount_info.py

ADDITIONAL INFORMATION

Sanity and integration tests were run as follows:

ansible-test sanity azure_rm_storageaccount --color --junit -v
ansible-test sanity azure_rm_storageaccount_info --color --junit -v
ansible-test integration azure_rm_storageaccount --allow-destructive -v

l3ender added 17 commits April 22, 2022 18:11
@l3ender
remove unused storage imports
0d2fddd
@l3ender
correct test lints
dc672b2
@l3ender
update azure-storage dependency
1791c89
@l3ender
Merge remote-tracking branch 'upstream/dev' into storage-account-updates
7e946bb
@l3ender
fix storage blob test lint issues
9b5560b
@l3ender
Merge remote-tracking branch 'upstream/dev' into storage-account-updates
8d678eb
@l3ender
clean up storage test
e5c5664
@l3ender
correct blob issues
a26afb0
@l3ender
correct file upload with new APIs
af6a642
@l3ender
update storageblob for ansible-test
4348348
@l3ender
Merge remote-tracking branch 'upstream/dev' into storage-account-updates
d7e47b2
@l3ender
allow configuration of static website on storage account
04a8d26
@l3ender
add static website output to storage info module
62f1d21
@l3ender
Merge branch 'dev' into storage-static-website
9555b5a
@l3ender
handle blob client access for non-blob account types
a5de356
@l3ender
ensure static website props always returned
e8ca1a8
@l3ender
additional static website tests
c89d6c7
@l3ender l3ender marked this pull request as ready for review June 11, 2022 20:43
@l3ender
Copy link
Contributor Author

l3ender commented Jun 11, 2022

@Fred-sun Hello! This is a PR to allow new configuration functionality for a storage account's static website. Please review...thank you!

@l3ender l3ender mentioned this pull request Jun 11, 2022
Closed
@Fred-sun Fred-sun added medium_priority Medium priority work in In trying to solve, or in working with contributors ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Jun 13, 2022
@xuzhang3
Copy link
Collaborator

@l3ender LGTM

@xuzhang3 xuzhang3 merged commit a923c97 into ansible-collections:dev Jun 14, 2022
@xuzhang3 xuzhang3 deleted the storage-static-website branch June 14, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@xuzhang3 xuzhang3

Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable static website for storage account
3 participants
@l3ender @xuzhang3 @Fred-sun