Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new module for Azure NAT gateway #860

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

andreadecorte
Copy link
Contributor

SUMMARY

Gateway association with subnets to be handled in the subnet instance.
Add relevant integration tests.
I added a default value for SKU for consistency. REST API doesn't have a default value.
I took inspiration from the existing modules for handling of resources IDs.
Support for Public IP prefixes is not implemented, it can be done in a second time.

Fixes #794

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

Azure NAT Gataway

ADDITIONAL INFORMATION

Gateway association with subnets to be handled in the subnet instance.
Add relevant integration tests
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged new_module_pr Add new modules medium_priority Medium priority labels May 26, 2022
@alfwed
Copy link

alfwed commented May 26, 2022

Many thanks for this PR !
It would be great to also be able to specify the Public IP to associate with the gateway. My company is using a naming convention for every resource and although we badly need this module, we wouldn't be able to use it as it is because of the lack of the public IP option. Any chance you could add it too?

@andreadecorte
Copy link
Contributor Author

This is the case, you will be able to specify one or more existing public IP addresses as parameter for the NAT gateway. Unless you meant to use public IP prefixes, and this is indeed not included, as it required an additional new module, but it can come later

@alfwed
Copy link

alfwed commented May 31, 2022

Sorry I wasn't looking at the right module file. It looks perfectly fine to me 👍

@xuzhang3
Copy link
Collaborator

@andreadecorte LGTM

@xuzhang3 xuzhang3 merged commit 7b1611d into ansible-collections:dev Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_module_pr Add new modules ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support for NAT Gateways
4 participants