-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure container registry tags #830
Conversation
@Fred-sun Please take a look. Thank you! |
@l3ender Please change the module name to azure_rm_containerregistrytag. Be consistent with other module development. Thank you very much!
|
@Fred-sun PR is updated with review suggestions and sanity fixes. Please take another look...thank you! |
tests/integration/targets/azure_rm_containerregistry_tag/tasks/main.yml ---> tests/integration/targets/azure_rm_containerregistrytag/tasks/main.yml |
@l3ender If you upgrade azure-mgmt-containerregistry, please change the relevant modules that depend on this module as track1 and Track2 are incompatible. The modules that synchronize changes are as follows:
|
@Fred-sun I have updated the other modules you mentioned (any that use |
@l3ender n addition, can you authorize me to make some changes to this PR? Since some of the changes are not easy to describe, I will move forward with this PR merger as soon as possible. Thank you very much! |
Co-authored-by: Fred-sun <[email protected]>
Thanks for the review, @Fred-sun! I apologize for missing the updates to use You should have access to push changes to this PR/branch. Please let me know if you face any issue. Thank you! |
Hello @Fred-sun, anything else I can provide for this PR? Thank you! |
LGTM |
SUMMARY
This PR:
ISSUE TYPE
COMPONENT NAME
azure_rm_containerregistrytag
azure_rm_containerregistrytag_info
ADDITIONAL INFORMATION
Example usage:
The test suite can be run with the following playbook: