Persist SSL configuration for appgateway #746
Merged
+251
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fred-sun Please review. Thank you! |
|
Sorry for the few additional commits after requesting review, but it should be good to go now. Thanks! |
Fred-sun
added
enhancement
|
@l3ender Please! |
|
@Fred-sun - it is now corrected; thank you! |
|
Hi @Fred-sun, anything else needed for this PR? Thank you! |
|
@l3ender I will push forward the merger of this PR as soon as possible. Thank you very much! |
|
@Fred-sun I think this PR is good to release. Let me know if I can add anything else--thank you! |
Fred-sun
reviewed
Apr 7, 2022
Fred-sun
added
ready_for_review
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR resolves a bug where SSL policy configuration is not set for an application gateway.
Resolves #287.
ISSUE TYPE
COMPONENT NAME
azure_rm_appgateway
ADDITIONAL INFORMATION
The module input was not being provided to the parameters of the API. I have corrected that while ensuring idempotency, added SSL policy configuration as output in the info module, and added test coverage.
Because the configuration was never applied before, the test cases also needed to be updated because they were using a combination of SSL parameters not supported by the API: