Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add private_dns_zone_id for azure_rm_privateendpointdnszonegroup #735

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Add private_dns_zone_id for azure_rm_privateendpointdnszonegroup #735

merged 2 commits into from
Feb 7, 2022
+13 −3

Conversation

Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented Jan 25, 2022 •
edited
Loading

SUMMARY

Add private_dns_zone_id for azure_rm_privateendpointdnszonegroup

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

azure_rm_privateendpointdnszonegroup.py

ADDITIONAL INFORMATION

@Fred-sun Fred-sun mentioned this pull request Jan 25, 2022
Closed
adthorn
adthorn approved these changes Jan 25, 2022
View reviewed changes
Copy link

@adthorn adthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it would fix my problem! It complains about the zone not being located in that subscription and if I put the whole var in the it adds /subscription to the full length. This should resolve it

adthorn
adthorn previously approved these changes Jan 25, 2022
View reviewed changes
Copy link

@adthorn adthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it would fix my problem! It complains about the zone not being located in that subscription and if I put the whole var in the it adds /subscription to the full length. This should resolve it

@Fred-sun Fred-sun added enhancement New feature or request medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged labels Jan 27, 2022
@adthorn
Copy link

adthorn commented Jan 28, 2022

Can anyone review this? I'd like to be able to try it out asap.

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Feb 7, 2022

LGTM

@xuzhang3 xuzhang3 merged commit 725c77d into ansible-collections:dev Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adthorn adthorn adthorn left review comments

Assignees

@xuzhang3 xuzhang3

Labels
enhancement New feature or request medium_priority Medium priority new_feature New feature requirments ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Fred-sun @adthorn @xuzhang3