-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module for private endpoint DNS zone groups #689
Add module for private endpoint DNS zone groups #689
Conversation
Hello @Fred-sun, here is the PR I mentioned for private endpoint. It turns out no update to Please review and advise--thank you! |
@l3ender Okay, we'll move forward with the merger as soon as possible. Thank you for your contribution! |
Co-authored-by: Fred-sun <[email protected]>
… into private-endpoint-dns-zones
Thanks for the review, @Fred-sun. The reference to extending tag documentation was a mistake: this resource does not support tags. I have updated that and also fixed lint issues. Please review again and let me know if there are any other items! |
Hello, wondering if there is anything else I can do for this PR? Thank you! |
@l3ender We are reviewing and will push forward the merger as soon as possible. Thank you very much! |
LGTM |
SUMMARY
This PR adds a new module for configuring private endpoint DNS zone groups and is comparable to the similar function in azure-cli. This is necessary when adding a private endpoint to a resource so that the private DNS entry will be used for the resource from within the vnet.
Consider the following example, where a Postgres server has already been created and added to an existing virtual network. The endpoint can be created:
However, the above by itself does not assign a private IP address to the Postgres server. The following must be done in order for that to occur:
Here is output from a sample usage of the
azure_rm_privateendpointdnszonegroup
module:Within the vnet, the hostname
postgresqlsrv-ef45326965.postgres.database.azure.com
can now be queried and it will return the private IP address for the Postgres server:-> nslookup postgresqlsrv-ef45326965.postgres.database.azure.com Server: 127.0.0.53 Address: 127.0.0.53#53 Non-authoritative answer: postgresqlsrv-ef45326965.postgres.database.azure.com canonical name = postgresqlsrv-ef45326965.privatelink.postgres.database.azure.com. Name: postgresqlsrv-ef45326965.privatelink.postgres.database.azure.com Address: 10.1.0.4
ISSUE TYPE
COMPONENT NAME
azure_rm_privateendpointdnszonegroup
azure_rm_privateendpointdnszonegroup_info
ADDITIONAL INFORMATION
I found similar type of configuration in the
azure_rm_privateendpoint
module, but it was not functional and the private endpoint SDK did not support it. I have removed it to clarify usage.Test coverage has been added (and acts as an example) in
tests/integration/targets/azure_rm_privateendpointdnszonegroup/tasks/main.yml
. It can be tested with the following playbook: