-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimizing ado.sh #510
Merged
Merged
Optimizing ado.sh #510
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
8aa47c9
check python version
Fred-sun 295a1e3
add new change
Fred-sun 82a6d81
ad new
Fred-sun fb1941f
for test
Fred-sun 7116e56
check python version
Fred-sun 9643fc7
update ado.sh
Fred-sun c364c82
add new change
Fred-sun 0ef27df
add new change
Fred-sun 0ce6d2d
Merge branch 'dev' into fix-sanity02
Fred-sun 61b1315
Perfect the ado.sh
Fred-sun 3fe2100
fix sanity 2.7 error
Fred-sun f8e17fc
delete virtual env set
Fred-sun d8c8d21
fix small
Fred-sun cbb2f6b
revert virtual env change
Fred-sun 2f72037
Merge branch 'dev' into fix-sanity02
Fred-sun c3e6d59
fixing update account_enabled bug in azure_rm_aduser.py (#524)
haiyuazhang 6fdfefe
fixing ad related auth issue when using service pricinpal. (#525)
haiyuazhang 24b08f7
change class name of azure_rm_aduser (#526)
haiyuazhang 29dd154
Merge branch 'dev' into fix-sanity02
Fred-sun a0c3416
Merge branch 'dev' into fix-sanity02
Fred-sun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
voluptuous==0.11.7 | ||
pycodestyle==2.6.0 | ||
yamllint==1.24.2 | ||
pylint==2.5.3 | ||
cryptography==3.3.2 | ||
pylint==2.5.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you check if
"$UID" -eq "0"
here instead of always performing sudo? It would be nice to be able to run this easily from inside a Docker container