-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module azure_rm_managementgroup_info #428
New module azure_rm_managementgroup_info #428
Conversation
…managementgroup-info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add follow lines to ~/tests/sanity/ignore-2.10.txt and ~/tests/sanity/ignore-2.11.txt
plugins/modules/azure_rm_managementgroup_info.py validate-modules:required_if-requirements-unknown
plugins/modules/azure_rm_managementgroup_info.py validate-modules:required_if-unknown-key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the ANSIBLE_METADATA block, it is no longer needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add "disabled" to tests/integration/targets/azure_rm_managementgroup/aliases, Thank you very mcuh!
Hello, Your suggestions have been committed. Thank you for the review @Fred-sun |
Co-authored-by: Fred-sun <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paultaiton It's my mistake! Please add follow lines to ~/tests/sanity/ignore-2.10.txt
plugins/modules/azure_rm_managementgroup_info.py validate-modules:required_if-requirements-unknown
plugins/modules/azure_rm_managementgroup_info.py validate-modules:required_if-unknown-key
Co-authored-by: Fred-sun <[email protected]>
Co-authored-by: Fred-sun <[email protected]>
haha, I was wondering. No problem sir, we're all on the same team. |
@paultaiton There should be no problem. We will complete the review as soon as possible and recommend the merger! Thank you very much! |
Awesome. Thank you very much @Fred-sun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow other module's define!
…managementgroup-info
Co-authored-by: Fred-sun <[email protected]>
@Fred-sun |
Thanks @haiyuazhang , appreciate it. |
SUMMARY
info module for management groups.
ISSUE TYPE
COMPONENT NAME
azure_rm_managementgroup_info
ADDITIONAL INFORMATION
This is a read only info module for querying Azure RM and gather details about management groups.
I have added integration test tasks, but I'm not sure what kind of role assignments exist for the test accounts, and can't be 100% certain they will work. It requires at least 1 management group exists which the principal has reader access to.