Azure rm role 20201018 #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Fred-sun
reviewed
Oct 22, 2020
Co-authored-by: Fred-sun <[email protected]>
|
@Fred-sun |
|
@Fred-sun |
I will recheck this! Thank you very much! |
Fred-sun
added
medium_priority
Fred-sun
reviewed
Nov 4, 2020
Fred-sun
added
ready_for_review
|
Thank you @Fred-sun and @haiyuazhang , I know this was a large change to review, so I appreciate your effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes multiple bugs, along with general cleanup and improvement of azure_rm_roleassignment and info modules. The additions in this PR are assuming the merging of #288 since there are shared dependencies created in azure_rm_common.py . Since I have created this branch from the branch pushed in #288, this PR strictly supersedes that one.
Besides improving detection of existing assignments for idempotency purposes, and more closely aligning the ansible module with the python SDK's requirements, there are 3 main methods for identifying a unique role assignment that have been further developed:
id: passing the fqid to get_by_id(id) in python sdk
scope and name: makes a call to get(scope, name) in the python sdk
scope, assignee_object_id and role_definition_id: fetches a list of all assignments, and filters to the (if exists,) single possible unique instance.
Fixes #145
Fixes #266
Fixes #283
ISSUE TYPE
COMPONENT NAME
azure_rm_roleassignment
azure_rm_roleassignment_info
ADDITIONAL INFORMATION
I have included integration tests for roleassignment modules, however I'm not certain what the test environment looks like, so I had to assume what would be OK to assign and delete based on a variable "{{ resource_group }}" that I've seen in other tests. If this needs changing let me know.