resolved issue #142 #264

ShwetaliBerad · 2020-09-18T12:53:12Z

SUMMARY

Fixes #142

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

azure_rm_subnet

ADDITIONAL INFORMATION

Subnet delegation enables you to designate a specific subnet for an Azure PaaS service of your choice that needs to be injected into your virtual network. Subnet delegation provides full control to the customer on managing the integration of Azure services into their virtual networks.
When you delegate a subnet to an Azure service, you allow that service to establish some basic network configuration rules for that subnet, which help the Azure service operate their instances in a stable manner. As a result, the Azure service may establish some pre or post deployment conditions, such as:

deploy the service in a shared versus dedicated subnet.
add to the service a set of Network Intent Policies post deployment that is required for the service to work properly.

Sample output:

TASK [Add subnet] ****************************************************************************************************************************
task path: /home/shwetali/Ansible/azure_subnet.yaml:21
changed: [localhost] => {
    "changed": true,
    "invocation": {
        "module_args": {
            "ad_user": null,
            "address_prefix": "10.0.1.0/24",
            "address_prefix_cidr": "10.0.1.0/24",
            "adfs_authority_url": null,
            "api_profile": "latest",
            "auth_source": null,
            "cert_validation_mode": null,
            "client_id": null,
            "cloud_environment": "AzureCloud",
            "delegations": [
                {
                    "name": "mydeleg",
                    "serviceName": "Microsoft.ContainerInstance/containerGroups"
                }
            ],
            "name": "test1",
            "password": null,
            "profile": null,
            "resource_group": "test1",
            "route_table": null,
            "secret": null,
            "security_group": null,
            "service_endpoints": null,
            "state": "present",
            "subscription_id": null,
            "tenant": null,
            "virtual_network": "test1",
            "virtual_network_name": "test1"
        }
    },
    "state": {
        "address_prefix": "10.0.1.0/24",
        "delegations": [
            {
                "actions": [
                    "Microsoft.Network/virtualNetworks/subnets/action"
                ],
                "name": "mydeleg",
                "serviceName": "Microsoft.ContainerInstance/containerGroups"
            }
        ],
        "id": "/subscriptions/<subscription_id>/resourceGroups/test1/providers/Microsoft.Network/virtualNetworks/test1/subnets/test1",
        "name": "test1",
        "network_security_group": {},
        "provisioning_state": "Succeeded",
        "route_table": {}
    }
}

ShwetaliBerad · 2020-09-18T13:11:09Z

@Fred-sun can you please review this PR ?

…to issue-142

plugins/modules/azure_rm_subnet.py

ShwetaliBerad · 2020-09-23T14:32:27Z

@Fred-sun @haiyuazhang updated arg_spec according to review comments , also please check comment for removal of line elements='dict'

ShwetaliBerad · 2020-09-29T14:07:57Z

@Fred-sun Any feedback on this ? Please check above comments

Fred-sun · 2020-09-30T02:47:48Z

RROR: Found 12 pep8 issue(s) which need to be resolved:
ERROR: plugins/modules/azure_rm_subnet.py:267:161: E501: line too long (261 > 160 characters)
ERROR: plugins/modules/azure_rm_subnet.py:267:262: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_subnet.py:268:1: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:268:161: E501: line too long (256 > 160 characters)
ERROR: plugins/modules/azure_rm_subnet.py:268:257: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_subnet.py:269:1: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:269:161: E501: line too long (271 > 160 characters)
ERROR: plugins/modules/azure_rm_subnet.py:269:272: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_subnet.py:270:1: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:270:161: E501: line too long (271 > 160 characters)
ERROR: plugins/modules/azure_rm_subnet.py:270:272: W291: trailing whitespace
ERROR: plugins/modules/azure_rm_subnet.py:271:1: E128: continuation line under-indented for visual indent
RROR: plugins/modules/azure_rm_subnet.py:0:0: doc-choices-do-not-match-spec: Argument 'serviceName' in argument_spec found in delegations defines choices as (['Microsoft.Web/serverFarms', 'Microsoft.ContainerInstance/containerGroups', 'Microsoft.Netapp/volumes', 'Microsoft.HardwareSecurityModules/dedicatedHSMs', 'Microsoft.ServiceFabricMesh/networks', 'Microsoft.Logic/integrationServiceEnvironments', 'Microsoft.Batch/batchAccounts', 'Microsoft.Sql/managedInstances', 'Microsoft.Web/hostingEnvironments', 'Microsoft.BareMetal/CrayServers', 'Microsoft.BareMetal/MonitoringServers', 'Microsoft.Databricks/workspaces', 'Microsoft.BareMetal/AzureHostedService', 'Microsoft.BareMetal/AzureVMware', 'Microsoft.BareMetal/AzureHPC', 'Microsoft.BareMetal/AzurePaymentHSM', 'Microsoft.StreamAnalytics/streamingJobs', 'Microsoft.DBforPostgreSQL/serversv2', 'Microsoft.AzureCosmosDB/clusters', 'Microsoft.MachineLearningServices/workspaces', 'Microsoft.DBforPostgreSQL/singleServers', 'Microsoft.DBforPostgreSQL/flexibleServers', 'Microsoft.DBforMySQL/serversv2', 'Microsoft.DBforMySQL/flexibleServers', 'Microsoft.ApiManagement/service', 'Microsoft.Synapse/workspaces', 'Microsoft.PowerPlatform/vnetaccesslinks', 'Microsoft.Network/managedResolvers', 'Microsoft.Kusto/clusters']) but documentation defines choices as ([])
ERROR: plugins/modules/azure_rm_subnet.py:0:0: doc-elements-mismatch: Argument 'delegations' in argument_spec specifies elements as dict,but elements is not documented

tests/integration/targets/azure_rm_subnet/tasks/main.yml

ShwetaliBerad · 2020-09-30T10:24:32Z

@Fred-sun updated test as per the review comments

Fred-sun

Add a line to the following file: plugins/modules/azure_rm_subnet.py Validate -modules:doc-elements-mismatch

tests/sanity/ignore-2.10.txt
tests/sanity/ignore-2.11.txt

plugins/modules/azure_rm_subnet.py

ShwetaliBerad · 2020-10-13T07:20:26Z

Add a line to the following file: plugins/modules/azure_rm_subnet.py Validate -modules:doc-elements-mismatch
tests/sanity/ignore-2.10.txt
tests/sanity/ignore-2.11.txt

Done

ShwetaliBerad · 2020-10-13T07:25:04Z

@Fred-sun Please check updated PR commits

Fred-sun

308,309,310,311,312,313,314,315,316 --- continuation line under-indented for visual indent!

tests/integration/targets/azure_rm_subnet/tasks/main.yml

plugins/modules/azure_rm_subnet.py

Co-authored-by: Fred-sun <[email protected]>

ShwetaliBerad · 2020-10-16T06:08:47Z

@Fred-sun made changes as suggested. Any more change required at lines 308,309,310,311,312,313,314,315,316 in plugins/modules/azure_rm_subnet.py ?

ShwetaliBerad · 2020-10-20T15:11:58Z

@Fred-sun could you please review changes ?

Fred-sun · 2020-10-22T05:47:20Z

@Fred-sun could you please review changes ?

ERROR: plugins/modules/azure_rm_subnet.py:308:17: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:309:17: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:310:17: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:311:17: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:312:17: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:313:17: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:314:17: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:315:17: E128: continuation line under-indented for visual indent
ERROR: plugins/modules/azure_rm_subnet.py:316:17: E128: continuation line under-indented for visual indent

ShwetaliBerad · 2020-10-24T09:08:30Z

@Fred-sun can you review now ?

tests/integration/targets/azure_rm_subnet/tasks/main.yml

Co-authored-by: Fred-sun <[email protected]>

ShwetaliBerad · 2020-10-26T06:46:20Z

@Fred-sun : made changes as suggested ..kindly check

Fred-sun · 2020-10-26T12:14:19Z

@ShwetaliBerad Test pass, I will push for merge!

ShwetaliBerad · 2020-10-26T15:05:53Z

@Fred-sun Thanks!

ShwetaliBerad added 2 commits September 18, 2020 18:14

resolved issue ansible-collections#142

1f66ee4

Merge branch 'dev' into issue-142

f52f6a3

ShwetaliBerad added 5 commits September 18, 2020 19:30

updated subnet info module and return info

1c23614

Merge branch 'issue-142' of https://github.com/ShwetaliBerad/azure in…

70baa15

…to issue-142

updated integration test cases

d485389

updated documentation

737b8be

updated documentation

2174e40

Fred-sun reviewed Sep 21, 2020

View reviewed changes

plugins/modules/azure_rm_subnet.py Outdated Show resolved Hide resolved

plugins/modules/azure_rm_subnet.py Show resolved Hide resolved

Fred-sun reviewed Sep 21, 2020

View reviewed changes

plugins/modules/azure_rm_subnet.py Show resolved Hide resolved

ShwetaliBerad added 2 commits September 21, 2020 20:59

fixed suggested changes

d654a37

fixed suggested changes

2cbc48e

Fred-sun reviewed Sep 22, 2020

View reviewed changes

updated argument spec

e789d73

Merge branch 'dev' into issue-142

869af60

next-davidduquehernandez mentioned this pull request Sep 29, 2020

Added force deletion capability to log analytics module and updated requirements.txt #273

Merged

Fred-sun reviewed Sep 30, 2020

View reviewed changes

tests/integration/targets/azure_rm_subnet/tasks/main.yml Outdated Show resolved Hide resolved

Fred-sun added work in In trying to solve, or in working with contributors medium_priority Medium priority labels Sep 30, 2020

ShwetaliBerad added 2 commits September 30, 2020 15:11

updated test and module as per the review comments

3a38442

updated exmaple in doc

4336fd5

ShwetaliBerad and others added 3 commits September 30, 2020 15:54

Merge branch 'dev' into issue-142

523b037

Merge branch 'dev' into issue-142

3ce5972

Merge branch 'dev' into issue-142

1abab29

Fred-sun reviewed Oct 10, 2020

View reviewed changes

plugins/modules/azure_rm_subnet.py Show resolved Hide resolved

updated documentation and sanity test files

d5aedee

Merge branch 'dev' into issue-142

6d3a77d

ShwetaliBerad closed this Oct 13, 2020

ShwetaliBerad reopened this Oct 13, 2020

Fred-sun reviewed Oct 14, 2020

View reviewed changes

tests/integration/targets/azure_rm_subnet/tasks/main.yml Outdated Show resolved Hide resolved

plugins/modules/azure_rm_subnet.py Outdated Show resolved Hide resolved

ShwetaliBerad and others added 3 commits October 16, 2020 11:28

Update tests/integration/targets/azure_rm_subnet/tasks/main.yml

63b2fdf

Co-authored-by: Fred-sun <[email protected]>

Update plugins/modules/azure_rm_subnet.py

930f7ad

Co-authored-by: Fred-sun <[email protected]>

Merge branch 'dev' into issue-142

fcf5904

ShwetaliBerad added 3 commits October 16, 2020 11:40

updated test cases

69961db

updated documentation

d48844b

updated documentation

22ddd67

fixed indentation error

515f9a2

Fred-sun reviewed Oct 24, 2020

View reviewed changes

tests/integration/targets/azure_rm_subnet/tasks/main.yml Outdated Show resolved Hide resolved

tests/integration/targets/azure_rm_subnet/tasks/main.yml Outdated Show resolved Hide resolved

ShwetaliBerad and others added 3 commits October 26, 2020 12:06

Update tests/integration/targets/azure_rm_subnet/tasks/main.yml

b97adf7

Co-authored-by: Fred-sun <[email protected]>

Update tests/integration/targets/azure_rm_subnet/tasks/main.yml

00c4b27

Co-authored-by: Fred-sun <[email protected]>

Merge branch 'dev' into issue-142

417bfd4

Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Oct 26, 2020

Merge branch 'dev' into issue-142

e834ded

haiyuazhang merged commit 8d7fc53 into ansible-collections:dev Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

resolved issue #142 #264

resolved issue #142 #264

ShwetaliBerad commented Sep 18, 2020

ShwetaliBerad commented Sep 18, 2020

ShwetaliBerad commented Sep 23, 2020

ShwetaliBerad commented Sep 29, 2020

Fred-sun commented Sep 30, 2020

ShwetaliBerad commented Sep 30, 2020

Fred-sun left a comment

ShwetaliBerad commented Oct 13, 2020 •

edited

Loading

ShwetaliBerad commented Oct 13, 2020

Fred-sun left a comment

ShwetaliBerad commented Oct 16, 2020

ShwetaliBerad commented Oct 20, 2020

Fred-sun commented Oct 22, 2020

ShwetaliBerad commented Oct 24, 2020

ShwetaliBerad commented Oct 26, 2020

Fred-sun commented Oct 26, 2020

ShwetaliBerad commented Oct 26, 2020

resolved issue #142 #264

resolved issue #142 #264

Conversation

ShwetaliBerad commented Sep 18, 2020

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ShwetaliBerad commented Sep 18, 2020

ShwetaliBerad commented Sep 23, 2020

ShwetaliBerad commented Sep 29, 2020

Fred-sun commented Sep 30, 2020

ShwetaliBerad commented Sep 30, 2020

Fred-sun left a comment

Choose a reason for hiding this comment

ShwetaliBerad commented Oct 13, 2020 • edited Loading

ShwetaliBerad commented Oct 13, 2020

Fred-sun left a comment

Choose a reason for hiding this comment

ShwetaliBerad commented Oct 16, 2020

ShwetaliBerad commented Oct 20, 2020

Fred-sun commented Oct 22, 2020

ShwetaliBerad commented Oct 24, 2020

ShwetaliBerad commented Oct 26, 2020

Fred-sun commented Oct 26, 2020

ShwetaliBerad commented Oct 26, 2020

ShwetaliBerad commented Oct 13, 2020 •

edited

Loading