Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suport msgraph sdk in ansible #1112

Closed
wants to merge 29 commits into from
Closed

Suport msgraph sdk in ansible #1112

wants to merge 29 commits into from

Conversation

Fred-sun
Copy link
Collaborator

SUMMARY

Suport msgraph sdk in ansible.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_msuser.py
azure_rm_msuser_info.py
azure_rm_msgroup.py
azure_rm_msgroup_info.py
azure_rm_msserviceprincipal.py
azure_rm_msserviceprincipal_info.py

ADDITIONAL INFORMATION

This was referenced Mar 20, 2023
Closed
Closed
Closed
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged new_module_pr Add new modules medium_priority Medium priority labels Mar 20, 2023
d2a-pnagel
d2a-pnagel suggested changes Mar 24, 2023
View reviewed changes
Copy link

@d2a-pnagel d2a-pnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I only have remarks on the descriptions / comments. Hope it helps.

d2a-pnagel
d2a-pnagel suggested changes Mar 24, 2023
View reviewed changes
Copy link

@d2a-pnagel d2a-pnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I only have remarks on the descriptions / comments. Hope it helps.

@Fred-sun
Copy link
Collaborator Author

Sorry, I only have remarks on the descriptions / comments. Hope it helps.

Update! Thanks for your review！

d2a-pnagel
d2a-pnagel previously approved these changes Mar 24, 2023
View reviewed changes
@Fred-sun Fred-sun mentioned this pull request Apr 3, 2023
Closed
This was referenced Apr 19, 2023
Closed
Closed
@Klaas- Klaas- mentioned this pull request Apr 25, 2023
Closed
@sboulkour
Copy link

Hello @Fred-sun !
Thx for your work on this, much appreciated :)

I have two question though :

  • are resources renamed from ad* to ms* to mark the switch from AD Graph to MS Graph ?
  • and in the listed resources I see some missing that would be of use for m personnal use case (azure_rm_adapplication), is it possible to add it to your current PR ?

@Fred-sun
Copy link
Collaborator Author

Fred-sun commented May 3, 2023

@sboulkour Yes, Graph RBAC will be migrated to MS Graph and we are adding azure_rm_adapplication and azure_rm_adpass modules! Thanks!

@kmj251
Copy link
Contributor

kmj251 commented Jun 12, 2023

Will this PR be merged, and an updated version of the collection released before Azure AD Graph is turned off on June 30, 2023?

@xuzhang3 xuzhang3 removed the ready_for_review The PR has been modified and can be reviewed and merged label Jun 27, 2023
@amarmh amarmh mentioned this pull request Jun 30, 2023
Closed
@Fred-sun
Copy link
Collaborator Author

Fred-sun commented Jul 5, 2023

Currently, msgraph-core cannot be directly used for aad management, and we are analyzing other ways to solve it. Shut it down for now.

@Fred-sun Fred-sun closed this Jul 5, 2023
@Fred-sun Fred-sun deleted the Add_msgrpah_support branch July 24, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2a-pnagel d2a-pnagel d2a-pnagel left review comments

Assignees

@xuzhang3 xuzhang3

Labels
medium_priority Medium priority new_module_pr Add new modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Fred-sun @sboulkour @kmj251 @d2a-pnagel @xuzhang3