Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selinux - add missing config keys when needed #52

Conversation

maxamillion
Copy link
Collaborator

SUMMARY

Previously the selinux module would only edit the state of found
configuration keys SELINUX and SELINUXTYPE in /etc/selinux/config but
would not add them with desired state if they were not found.

Fixes #23

#23

Signed-off-by: Adam Miller [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

selinux

Previously the selinux module would only edit the state of found
configuration keys SELINUX and SELINUXTYPE in /etc/selinux/config but
would not add them with desired state if they were not found.

Fixes ansible-collections#23

ansible-collections#23

Signed-off-by: Adam Miller <[email protected]>
@maxamillion maxamillion force-pushed the issues/23/selinux-doesnt-create-missing-config-keys branch from 6101c17 to cb54073 Compare June 18, 2020 22:29
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@@ -0,0 +1 @@
/.plugin-cache.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this is required since we have already here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Akasurde no, I actually don't know how that got in there ... must have messed up.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

@Akasurde Akasurde self-assigned this Jun 19, 2020
@maxamillion
Copy link
Collaborator Author

recheck

@maxamillion maxamillion added the gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate") label Jun 19, 2020
@maxamillion
Copy link
Collaborator Author

going ahead and gating since all other changes were approved and I need the changelog fragments dir structure in place for another PR

@Akasurde
Copy link
Member

recheck

@ansible-zuul ansible-zuul bot merged commit 39c09e7 into ansible-collections:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Gate PR in Zuul CI (Obsolete: Please set "mergeit" instead of "gate")
Projects
None yet
Development

Successfully merging this pull request may close these issues.

selinux modules don't change SELINUXTYPE when it's not exist in /etc/selinux/config.
2 participants