-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selinux - add missing config keys when needed #52
selinux - add missing config keys when needed #52
Conversation
ee4613d
to
6101c17
Compare
Previously the selinux module would only edit the state of found configuration keys SELINUX and SELINUXTYPE in /etc/selinux/config but would not add them with desired state if they were not found. Fixes ansible-collections#23 ansible-collections#23 Signed-off-by: Adam Miller <[email protected]>
6101c17
to
cb54073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
changelogs/.gitignore
Outdated
@@ -0,0 +1 @@ | |||
/.plugin-cache.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this is required since we have already here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Akasurde no, I actually don't know how that got in there ... must have messed up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed!
Signed-off-by: Adam Miller <[email protected]>
recheck |
going ahead and gating since all other changes were approved and I need the changelog fragments dir structure in place for another PR |
recheck |
SUMMARY
Previously the selinux module would only edit the state of found
configuration keys SELINUX and SELINUXTYPE in /etc/selinux/config but
would not add them with desired state if they were not found.
Fixes #23
#23
Signed-off-by: Adam Miller [email protected]
ISSUE TYPE
COMPONENT NAME
selinux