synchronize: fix to honor become_user when become_method sudo

[smemsh]

SUMMARY

When become_method is sudo, the synchronize module ignores become_user, always running as root. This means one cannot create files as a target user, when they need to get in via a third user and can only sudo via that one. In my case, I'm connecting via a special provisioning user that has sudo privs, but I need to create the files as the become_user. I'm using it to deposit skeleton files, and there should be no reason to run another task with chown; after all, the documentation already describes the desired behavior:

The user and permissions for the synchronize dest are those of the remote_user on the destination host or the become_user if become=yes is active.

This patch takes the running become_user (if it's not None) and adds it to the sudo command with the -u command line option, so the file gets created correctly. I have tested this and it works.

Other become_methods are ignored, but they already were anyways (the code already has a TODO to add other methods, which we don't attempt in this patch)

Fixes #186

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

synchronize

ADDITIONAL INFORMATION

See reproduction in #186.

This appears to have been in place since ansible/ansible@811a906

[smemsh]

The changelog fragment apparently has to be in the last commit? That doesn't seem right. It means one can't add commits to the branch tip without an interactive rebase every time to reorder them. The command it's using to determine is:

shell: git show --name-status --exit-code --oneline --diff-filter=A | grep changelogs/fragments/

but shouldn't it use instead:

shell: git show {{basebranch}}.. --name-status --exit-code --oneline --diff-filter=A | grep changelogs/fragments/

I don't know the right name for the templated branch variable ie {{basebranch}}, but I would think it should be using that, so it's looking at the whole diff in the patch and not just the last commit. My changelog fragment was there and I had to reorder it to be the last commit just for the fragment detection rule to work.

[aminvakil]

Thanks for your contribution!
You're right about changelog fragment check bug, I can't find the repository to open an issue/PR to fix this bug right now.

[smemsh]

my patch was working fine, then after only a trivial change to changelog fragment was made, now this:

ERROR! Collection artifact at 'collections/cisco-nxos-2.2.1-dev4.tar.gz' is not a valid tar file.

not clear what that has to do with my patch?

[aminvakil]

I would just ignore the CI :)
Feel free to close/reopen the PR to test again, as I've found some times which bot commands (rebuild_failed, recheck) does not work either.
Closing/reopening always work though ;)

[smemsh]

the repository for CI bugs might be https://github.com/ansible/ansibullbot

[smemsh]

recheck

[smemsh]

FYI, don't see the changelog fragment detection code in ansibullbot repo anywhere, so it must be somewhere else

[Akasurde]

@quidame @aminvakil Could you please review this and let me know? Thanks in advance.

[aminvakil]

LGTM

[Akasurde]

recheck