Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep 0.2.0 release #24

Merged
merged 3 commits into from
Aug 31, 2022
Merged

Prep 0.2.0 release #24

merged 3 commits into from
Aug 31, 2022

Conversation

alinabuzachis
Copy link
Collaborator

@alinabuzachis alinabuzachis commented Aug 23, 2022 •
edited by gravesm
Loading

Depends-on: ansible/ansible-zuul-jobs#1616

SUMMARY

Run add_docs, generate changelog

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Aug 23, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 43s
✔️ build-ansible-collection SUCCESS in 3m 23s
❌ ansible-test-sanity-docker-devel FAILURE in 8m 03s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 7m 31s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 9m 12s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 11m 19s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 2m 53s

@alinabuzachis alinabuzachis force-pushed the prep_0_2_0 branch 4 times, most recently from f37d0d3 to 41a4d79 Compare August 23, 2022 17:51
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 3m 27s
❌ ansible-test-sanity-docker-devel FAILURE in 7m 06s (non-voting)
❌ ansible-test-sanity-docker-milestone FAILURE in 8m 14s
❌ ansible-test-sanity-docker-stable-2.11 FAILURE in 8m 30s
❌ ansible-test-sanity-docker-stable-2.12 FAILURE in 7m 29s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 2m 34s

@alinabuzachis alinabuzachis force-pushed the prep_0_2_0 branch 4 times, most recently from dbb6f32 to dacc9bb Compare August 23, 2022 18:22
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 3m 42s
✔️ ansible-test-sanity-docker-devel SUCCESS in 6m 49s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 17s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 53s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 17s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 2m 56s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 45s
✔️ build-ansible-collection SUCCESS in 3m 17s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 20s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 6m 37s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 00s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 56s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 2m 44s

@alinabuzachis alinabuzachis force-pushed the prep_0_2_0 branch 2 times, most recently from 84da4c8 to d8ba1d7 Compare August 24, 2022 12:24
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 19s
✔️ build-ansible-collection SUCCESS in 3m 20s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 55s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 24s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 44s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 02s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 2m 51s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 19s
✔️ build-ansible-collection SUCCESS in 3m 24s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 39s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 32s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 35s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 57s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 2m 42s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 17s
✔️ build-ansible-collection SUCCESS in 3m 24s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 08s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 6m 39s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 48s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 02s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 2m 54s

@alinabuzachis alinabuzachis changed the title [Test] Prep 0.2.0 release Prep 0.2.0 release Aug 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 3m 30s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 25s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 24s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 59s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 53s
❌ ansible-test-integration-amazon-cloud FAILURE in 8m 38s

@alinabuzachis
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 53s
✔️ build-ansible-collection SUCCESS in 3m 24s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 27s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 9m 21s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 04s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 39s
❌ ansible-test-integration-amazon-cloud FAILURE in 9m 06s

@alinabuzachis
Prep 0.2.0 release
a9c10d5 
Run add_docs, generate changelog

Signed-off-by: Alina Buzachis <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 25s
✔️ build-ansible-collection SUCCESS in 3m 38s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 00s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 6m 57s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 52s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 20s
❌ ansible-test-integration-amazon-cloud FAILURE in 6m 50s

@alinabuzachis alinabuzachis requested review from gravesm and jillr August 29, 2022 09:01
gravesm
gravesm reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confess I didn't read all 20,000 lines of changes 😅. Everything in module_utils has already gone through review. I picked a couple modules and looked at changes for the module and docs to make sure the generation process turned out ok. Overall, looks good. Spotted a couple small things.

plugins/modules/cloudtrail_event_data_store.py Outdated
module: cloudtrail_event_data_store
short_description: Creates and manages a new event data store
description:
- Creates and manages Creates a new event data store.a new event data store.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use a little cleaning up. Looks like probably some bad copy paste.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the docs and in the generator repo https://github.com/ansible-collections/amazon_cloud_code_generator/pull/49/files

docs/amazon.cloud.cloudtrail_event_data_store_module.rst Outdated

- boto3 >= 1.17.0
- botocore >= 1.20.0
- python >= 3.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to include jsonpatch.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

jillr
jillr reviewed Aug 29, 2022
View reviewed changes
Copy link
Contributor

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also did not exhaustively read the generated docs but did catch a couple things.

@alinabuzachis alinabuzachis force-pushed the prep_0_2_0 branch 2 times, most recently from 4d5e15b to 426937f Compare August 30, 2022 12:31
@alinabuzachis alinabuzachis requested review from gravesm and jillr August 30, 2022 12:35
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 3m 52s
✔️ build-ansible-collection SUCCESS in 4m 14s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 44s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 23s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 18s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 10s
❌ ansible-test-integration-amazon-cloud FAILURE in 40m 47s

@alinabuzachis
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 4m 21s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 00s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 53s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 31s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 35s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 38m 46s

jillr
jillr reviewed Aug 30, 2022
View reviewed changes
plugins/modules/cloudtrail_event_data_store.py Outdated
@@ -15,7 +15,7 @@
module: cloudtrail_event_data_store
short_description: Creates and manages a new event data store
description:
- Creates and manages Creates a new event data store.a new event data store.
- Creates and manages Creates a new event data store.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Creates and manages Creates a new event data store.
- Creates and manages Creates a new event data store.

Still some duplicate text here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jillr Done, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm still seeing on old cached version, but it doesn't look like the change in the generator collection is reflected here. What I'm seeing: Creates and manages Creates a new event data store.. This should read Creates and manages a new event data store.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed now! Thanks.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 4m 44s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 33s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 8m 19s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 9m 30s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 9m 26s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 40m 37s

@alinabuzachis alinabuzachis force-pushed the prep_0_2_0 branch 2 times, most recently from 9dd75ba to e5e666b Compare August 31, 2022 08:44
@alinabuzachis alinabuzachis requested a review from jillr August 31, 2022 08:48
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 4m 09s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 22s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 33s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 11m 02s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 28s
❌ ansible-test-integration-amazon-cloud FAILURE in 38m 04s

@alinabuzachis
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 4m 34s
✔️ ansible-test-sanity-docker-devel SUCCESS in 7m 28s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 29s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 53s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 8m 27s
❌ ansible-test-integration-amazon-cloud FAILURE in 38m 52s

@alinabuzachis
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 25s
✔️ build-ansible-collection SUCCESS in 4m 06s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 04s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 51s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 11s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 10s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 41m 28s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 4m 22s
✔️ ansible-test-sanity-docker-devel SUCCESS in 10m 12s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 49s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 8m 16s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 12s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 42m 14s

@jillr jillr added the mergeit label Aug 31, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 42s
✔️ build-ansible-collection SUCCESS in 4m 56s
✔️ ansible-test-sanity-docker-devel SUCCESS in 9m 07s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 7m 51s
✔️ ansible-test-sanity-docker-stable-2.11 SUCCESS in 10m 44s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 7m 08s
✔️ ansible-test-integration-amazon-cloud SUCCESS in 41m 29s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit de6a071 into ansible-collections:main Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gravesm gravesm gravesm approved these changes

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alinabuzachis @gravesm @jillr