Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_instance - expand use of AWSRetry #928

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 14, 2022

SUMMARY

fixes: #927

A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

Copy link
Contributor

@briantist briantist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thank you!

@tremble tremble added backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch labels Jul 14, 2022
@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module owner_pr PR created by owner/maintainer plugins plugin (any type) labels Jul 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 5m 09s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 51s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 34s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 35s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 58s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 01s
✔️ ansible-test-splitter SUCCESS in 2m 37s
✔️ integration-amazon.aws-1 SUCCESS in 35m 03s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 6m 22s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 15, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 5m 16s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 15s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 41s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 04s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 37s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 00s
✔️ ansible-test-splitter SUCCESS in 2m 34s
✔️ integration-amazon.aws-1 SUCCESS in 43m 46s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 6m 26s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 524129f into ansible-collections:main Jul 15, 2022
@patchback
Copy link

patchback bot commented Jul 15, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/524129fcb5a8cebcea735cc0c83813205e0a160e/pr-928

Backported as #930

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 15, 2022
ec2_instance - expand use of AWSRetry

SUMMARY
fixes: #927
A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Brian Scholer <None>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 524129f)
@patchback
Copy link

patchback bot commented Jul 15, 2022

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/524129fcb5a8cebcea735cc0c83813205e0a160e/pr-928

Backported as #931

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 15, 2022
ec2_instance - expand use of AWSRetry

SUMMARY
fixes: #927
A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Brian Scholer <None>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit 524129f)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 15, 2022
[PR #928/524129fc backport][stable-4] ec2_instance - expand use of AWSRetry

This is a backport of PR #928 as merged into main (524129f).
SUMMARY
fixes: #927
A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jul 18, 2022
[PR #928/524129fc backport][stable-3] ec2_instance - expand use of AWSRetry

This is a backport of PR #928 as merged into main (524129f).
SUMMARY
fixes: #927
A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
@tremble tremble deleted the issues/927 branch September 9, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3 PR should be backported to the stable-3 branch backport-4 PR should be backported to the stable-4 branch community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module owner_pr PR created by owner/maintainer plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some code paths in ec2_instance are not using AWSRetry
4 participants