-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_instance - expand use of AWSRetry #928
ec2_instance - expand use of AWSRetry #928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thank you!
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #930 🤖 @patchback |
ec2_instance - expand use of AWSRetry SUMMARY fixes: #927 A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Brian Scholer <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 524129f)
Backport to stable-4: 💚 backport PR created✅ Backport PR branch: Backported as #931 🤖 @patchback |
ec2_instance - expand use of AWSRetry SUMMARY fixes: #927 A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Brian Scholer <None> Reviewed-by: Alina Buzachis <None> (cherry picked from commit 524129f)
[PR #928/524129fc backport][stable-4] ec2_instance - expand use of AWSRetry This is a backport of PR #928 as merged into main (524129f). SUMMARY fixes: #927 A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
[PR #928/524129fc backport][stable-3] ec2_instance - expand use of AWSRetry This is a backport of PR #928 as merged into main (524129f). SUMMARY fixes: #927 A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
SUMMARY
fixes: #927
A few code paths weren't using AWSRetry when the should have, probably a leftover from when retries included the NotFound exceptions.
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION