-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #739/df865b4c backport][stable-2] ec2_vol/test: gives more time to convert vol to gp3 #742
Merged
softwarefactory-project-zuul
merged 1 commit into
stable-2
from
patchback/backports/stable-2/df865b4c56d06c6086cb2d2443931122e9f03f10/pr-739
Apr 12, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@patchback[bot]: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
tremble
approved these changes
Apr 12, 2022
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#742) Add network load balancer example for specified internal IP address SUMMARY Adds an example to community.aws.elb_network_lb for creating an internally-facing ELB with a specified internal IP address. The subnet_mappings dictionary is passed directly through to the AWS ELB API, so the ability was inherent in the module but wasn't documented. ISSUE TYPE Docs Pull Request COMPONENT NAME community.aws.elb_network_lb ADDITIONAL INFORMATION No module change, just docs. Happy to make any requested changes. Thanks for this module and for looking at the PR. Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…nsible-collections#742) Add network load balancer example for specified internal IP address SUMMARY Adds an example to community.aws.elb_network_lb for creating an internally-facing ELB with a specified internal IP address. The subnet_mappings dictionary is passed directly through to the AWS ELB API, so the ability was inherent in the module but wasn't documented. ISSUE TYPE Docs Pull Request COMPONENT NAME community.aws.elb_network_lb ADDITIONAL INFORMATION No module change, just docs. Happy to make any requested changes. Thanks for this module and for looking at the PR. Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…nsible-collections#742) Add network load balancer example for specified internal IP address SUMMARY Adds an example to community.aws.elb_network_lb for creating an internally-facing ELB with a specified internal IP address. The subnet_mappings dictionary is passed directly through to the AWS ELB API, so the ability was inherent in the module but wasn't documented. ISSUE TYPE Docs Pull Request COMPONENT NAME community.aws.elb_network_lb ADDITIONAL INFORMATION No module change, just docs. Happy to make any requested changes. Thanks for this module and for looking at the PR. Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
needs_info
This issue requires further information. Please answer any outstanding questions
needs_template
This issue/PR has an incomplete description. Please fill in the proposed template correctly
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
small_patch
Hopefully easy to review
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #739 as merged into main (df865b4).
We give 9s to convert the volumne to gp3, in some cases this is not
enough.
Closes: #738