Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comment from the legacy_missing_tests suite #737

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Remove comment from the legacy_missing_tests suite #737

merged 1 commit into from
Mar 28, 2022

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

Remove comment from the legacy_missing_tests suite. The comment doesn't allow the splitter to match aws_ssm.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@alinabuzachis alinabuzachis added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Mar 25, 2022
@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review integration tests/integration small_patch Hopefully easy to review tests tests labels Mar 25, 2022
@alinabuzachis
Copy link
Collaborator Author

recheck

@alinabuzachis alinabuzachis reopened this Mar 25, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@alinabuzachis alinabuzachis added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Mar 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Mar 28, 2022

Pull request merge failed: Required status check "ansible/gate" is failing.

@alinabuzachis alinabuzachis added mergeit Merge the PR (SoftwareFactory) and removed gate labels Mar 28, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7297e31 into ansible-collections:main Mar 28, 2022
@patchback
Copy link

patchback bot commented Mar 28, 2022 •
edited
Loading

Backport to stable-2: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 7297e31 on top of patchback/backports/stable-2/7297e31ff637d99a356c13f3a57e24e5dc3ef82d/pr-737

Backporting merged PR #737 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-2/7297e31ff637d99a356c13f3a57e24e5dc3ef82d/pr-737 upstream/stable-2
  4. Now, cherry-pick PR Remove comment from the legacy_missing_tests suite #737 contents into that branch: 
    $ git cherry-pick -x 7297e31ff637d99a356c13f3a57e24e5dc3ef82d
    If it'll yell at you with something like fatal: Commit 7297e31ff637d99a356c13f3a57e24e5dc3ef82d is a merge but no -m option was given., add -m 1 as follows intead: 
    $ git cherry-pick -m1 -x 7297e31ff637d99a356c13f3a57e24e5dc3ef82d
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Remove comment from the legacy_missing_tests suite #737 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-2/7297e31ff637d99a356c13f3a57e24e5dc3ef82d/pr-737
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Mar 28, 2022 •
edited
Loading

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/7297e31ff637d99a356c13f3a57e24e5dc3ef82d/pr-737

Backported as #748

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 28, 2022
@alinabuzachis @patchback
remove comment it seems to not be picked up in the CI (#737)
33e7008 
Remove comment from the legacy_missing_tests suite

SUMMARY

Remove comment from the legacy_missing_tests suite. The comment doesn't allow the splitter to match aws_ssm.

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

(cherry picked from commit 7297e31)
@patchback patchback bot mentioned this pull request Mar 28, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 29, 2022
@patchback
remove comment it seems to not be picked up in the CI (#737) (#748)
3a0c159 
[PR #737/7297e31f backport][stable-3] Remove comment from the legacy_missing_tests suite

This is a backport of PR #737 as merged into main (7297e31).
SUMMARY

Remove comment from the legacy_missing_tests suite. The comment doesn't allow the splitter to match aws_ssm.

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Mar 31, 2022
@patchback @alinabuzachis
remove comment it seems to not be picked up in the CI (ansible-collec…
b910b6e 
…tions#737) (ansible-collections#748)

[PR ansible-collections#737/7297e31f backport][stable-3] Remove comment from the legacy_missing_tests suite

This is a backport of PR ansible-collections#737 as merged into main (7297e31).
SUMMARY

Remove comment from the legacy_missing_tests suite. The comment doesn't allow the splitter to match aws_ssm.

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@ansible-zuul
Merge pull request ansible-collections#737 from tremble/boto3/iam_cert
2d9ddb6 
iam_server_certificate - Migrate to boto3

SUMMARY
Migrate iam_server_certificate to boto3
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
iam_server_certificate

Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) small_patch Hopefully easy to review tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alinabuzachis @ansibullbot