Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_group: update documentation for specifying port ranges #436

Merged
merged 2 commits into from
Aug 9, 2021
Merged

ec2_group: update documentation for specifying port ranges #436

merged 2 commits into from
Aug 9, 2021

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Aug 3, 2021 •
edited by tremble
Loading

Depends-on: #429

SUMMARY

Added missing part of documentation for specifying port ranges as -1 value in parameter from_port and to_port is only supported for proto:icmp.

Fixes #397

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ec2_group

@ansibullbot
Copy link

cc @adq @jillr @s-hertel @tremble @wimnat
click here for bot help

@ansibullbot ansibullbot added community_review docs module module needs_triage new_contributor Help guide this first time contributor plugins plugin (any type) labels Aug 3, 2021
@jillr jillr requested a review from markuman August 3, 2021 23:51
jillr
jillr reviewed Aug 3, 2021
View reviewed changes
Copy link
Contributor

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

markuman
markuman approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@markuman markuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alinabuzachis
alinabuzachis approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@alinabuzachis alinabuzachis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mandar242. LGTM as well.

@alinabuzachis
Copy link
Collaborator

recheck

tremble
tremble requested changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit this PR.

A minor formatting niggle: the numbers should be wrapped in C() since they're values.
I'd also recommend splitting the description lines up rather than having one big line.

The ec2_group CI tests are currently broken, I've added a Depends-on against the PR which will disable the integration tests. Since this only touches the docs we just need the CI test suites not to fail.

@mandar242
Copy link
Contributor Author

Thanks for taking the time to submit this PR.

A minor formatting niggle: the numbers should be wrapped in C() since they're values.
I'd also recommend splitting the description lines up rather than having one big line.

The ec2_group CI tests are currently broken, I've added a Depends-on against the PR which will disable the integration tests. Since this only touches the docs we just need the CI test suites not to fail.

Thank you for the feedback.

@mandar242 mandar242 requested a review from tremble August 5, 2021 17:36
@jillr
Copy link
Contributor

jillr commented Aug 5, 2021

recheck

alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 6, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
b5c3a0c 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
@ansibullbot ansibullbot removed the new_contributor Help guide this first time contributor label Aug 9, 2021
@tremble
Copy link
Contributor

tremble commented Aug 9, 2021

recheck

@tremble tremble added the gate label Aug 9, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit c060264 into ansible-collections:main Aug 9, 2021
@mandar242 mandar242 deleted the issues-397-ec2_groups_documentation_fix branch August 9, 2021 17:29
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 12, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
ad7b9f4 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
72bf9cc 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
229e8c6 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
045bdff 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
522e92f 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
87ecec4 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 13, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
979baab 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
cae22eb 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
3b6d470 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
a7f5cfb 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
4e663d5 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
d351e44 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 23, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
3321d38 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit that referenced this pull request Aug 25, 2021
@alinabuzachis
Fix broken check_mode (#436)
86761d0 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit that referenced this pull request Aug 25, 2021
@alinabuzachis
Fix broken check_mode (#436)
c901cb6 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit that referenced this pull request Aug 26, 2021
@alinabuzachis
Fix broken check_mode (#436)
aad0157 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit that referenced this pull request Aug 26, 2021
@alinabuzachis
Fix broken check_mode (#436)
0745476 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
alinabuzachis added a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 26, 2021
@alinabuzachis
Fix broken check_mode (ansible-collections#436)
8ee039c 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
jillr pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Aug 27, 2021
@alinabuzachis @jillr
Fix broken check_mode (ansible-collections#436)
1c5950f 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@044b30c
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@alinabuzachis
[ec2_vpc_nat_gateway] Fix broken check_mode (ansible-collections#436)
6a5a96c 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@alinabuzachis @abikouo
[ec2_vpc_nat_gateway] Fix broken check_mode (ansible-collections#436)
4393181 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@alinabuzachis
[ec2_vpc_nat_gateway] Fix broken check_mode (ansible-collections#436)
044b30c 
* ec2_vpc_nat_gateway: fix broken check_mode
     * fix broken check_mode (remove hard coded values)
Signed-off-by: Alina Buzachis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr left review comments

@tremble tremble tremble approved these changes

@markuman markuman markuman approved these changes

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
community_review docs module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor documentation for from_port, to_port in ec2_groups
6 participants
@mandar242 @ansibullbot @alinabuzachis @jillr @tremble @markuman