[PR #2396/3c7e9eca backport][stable-9] Deprecate managing instances through autoscaling_group #2399
Conversation
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
SUMMARY Managing instances directly through autoscaling_group has lead to a significant sprawl in the code which is difficult to test. With Amazon now also supporting "Instance Refresh" through its own API we can handle rolling replacements using less home-brew code (available through autoscaling_instance_refresh). The autoscaling_instance also has support for a more complete set of attach/detach/standby/terminate functionality (including instance protection management). Deprecates the following parameters: replace_all_instances -> amazon.aws.autoscaling_instance_refresh replace_batch_size (tied to replace_all_instances) lc_check (tied to replace_all_instances) lt_check (tied to replace_all_instances) detach_instances -> amazon.aws.autoscaling_instance replace_instances -> amazon.aws.autoscaling_instance decrement_desired_capacity (tied to detach_instances and replace_instances) This functionality provided through these parameters is now available through autoscaling_instance and autoscaling_instance_refresh Also adds group_name as an alias for name on both autoscaling_instance_refresh and autoscaling_group for consistency with autoscaling_instance where name would be ambiguous. ISSUE TYPE Feature Pull Request COMPONENT NAME autoscaling_group autoscaling_instance autoscaling_instance_refresh ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell (cherry picked from commit 3c7e9ec)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 30s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 35s |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-9/3c7e9eca848857127f11b9aa16f5c2796ef4b8a8/pr-2396
branch
This is a backport of PR #2396 as merged into main (3c7e9ec).
SUMMARY
Managing instances directly through autoscaling_group has lead to a significant sprawl in the code which is difficult to test. With Amazon now also supporting "Instance Refresh" through its own API we can handle rolling replacements using less home-brew code (available through autoscaling_instance_refresh). The autoscaling_instance also has support for a more complete set of attach/detach/standby/terminate functionality (including instance protection management).
Deprecates the following parameters:
This functionality provided through these parameters is now available through autoscaling_instance and autoscaling_instance_refresh
Also adds
group_nameas an alias fornameon both autoscaling_instance_refresh and autoscaling_group for consistency with autoscaling_instance wherenamewould be ambiguous.ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION