fix(ec2_vol): output volume informations when volume exists in check mode #2133
Conversation
|
Hi @theredcat Thank you for working on this PR. Could you please rebase the branch and add a changelog to describe the changes made? |
alinabuzachis
force-pushed
the
patch-1
branch
5 times, most recently
from
8f1ca4d to
975541a
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 29s |
|
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/fac760c4758f4985b7804d4fb2d79ff6 ✔️ ansible-galaxy-importer SUCCESS in 4m 40s |
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
alinabuzachis
force-pushed
the
patch-1
branch
from
0639316 to
e4d9712
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 21s |
|
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/72faf69add5d478fb2c7666a8254f029 ✔️ ansible-galaxy-importer SUCCESS in 5m 52s |
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 46s |
softwarefactory-project-zuul
bot
merged commit fa31438
into
ansible-collections:main
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #2437 🤖 @patchback |
…mode (#2133) SUMMARY When using ec2_vol in check mode if the volume already exists and is attached, the module don't output the volume informations. This is problematic when used with a "register" directive when writing idempotent playbooks ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION Before : changed: false failed: false msg: 'IN CHECK MODE - volume already attached to instance: i-xxxxxxxxxxxxxxxxxxx.' After : attachments: - attach_time: '2024-05-17T15:14:49+00:00' delete_on_termination: false device: /dev/sdf instance_id: i-xxxxxxxxxxxxxxxxxxx state: attached volume_id: vol-xxxxxxxxxxxxxx availability_zone: eu-west-1a changed: false create_time: '2024-05-17T15:14:33.776000+00:00' encrypted: false failed: false iops: 3000 msg: 'IN CHECK MODE - volume already attached to instance: i-xxxxxxxxxxxxxxx.' multi_attach_enabled: false size: 30 snapshot_id: '' state: in-use tags: - key: Name value: xxxxxxxxxxxxxxxxxxxxxxxxxxxxx throughput: 125 volume_id: vol-xxxxxxxxxxxxxx volume_type: gp3 Reviewed-by: Alina Buzachis (cherry picked from commit fa31438)
…mode (#2133) (#2437) This is a backport of PR #2133 as merged into main (fa31438). SUMMARY When using ec2_vol in check mode if the volume already exists and is attached, the module don't output the volume informations. This is problematic when used with a "register" directive when writing idempotent playbooks ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vol ADDITIONAL INFORMATION Before : changed: false failed: false msg: 'IN CHECK MODE - volume already attached to instance: i-xxxxxxxxxxxxxxxxxxx.' After : attachments: - attach_time: '2024-05-17T15:14:49+00:00' delete_on_termination: false device: /dev/sdf instance_id: i-xxxxxxxxxxxxxxxxxxx state: attached volume_id: vol-xxxxxxxxxxxxxx availability_zone: eu-west-1a changed: false create_time: '2024-05-17T15:14:33.776000+00:00' encrypted: false failed: false iops: 3000 msg: 'IN CHECK MODE - volume already attached to instance: i-xxxxxxxxxxxxxxx.' multi_attach_enabled: false size: 30 snapshot_id: '' state: in-use tags: - key: Name value: xxxxxxxxxxxxxxxxxxxxxxxxxxxxx throughput: 125 volume_id: vol-xxxxxxxxxxxxxx volume_type: gp3 Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: GomathiselviS <[email protected]>
SUMMARY
When using ec2_vol in check mode if the volume already exists and is attached, the module don't output the volume informations.
This is problematic when used with a "register" directive when writing idempotent playbooks
ISSUE TYPE
COMPONENT NAME
ec2_vol
ADDITIONAL INFORMATION
Before :
After :