-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Object Lock default retention configuration for S3 buckets #2062
Add Object Lock default retention configuration for S3 buckets #2062
Conversation
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
8f57ebc
to
99375bb
Compare
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 5m 54s |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 44s |
ab58df0
to
ff9382b
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 08s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! See a few mostly minor comments below.
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 50s |
Thank you @hakbailey, I have addressed your comments, could you give it another look? |
Build failed.
|
retry |
recheck |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 14s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor comments. In addition, running tox -e black
locally should fix the linting errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abraverm Thank you for working on this feature idea. Can you please add a changelog fragment (https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment) for this change?
50a508c
to
f57b820
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 37s |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Signed-off-by: Alina Buzachis <[email protected]>
Signed-off-by: Alina Buzachis <[email protected]>
f57b820
to
03e0e28
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 51s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 36s |
c2e7aaf
into
ansible-collections:main
Backport to stable-8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply c2e7aaf on top of patchback/backports/stable-8/c2e7aaf5cadbf7873698edd3dce59ec53583e893/pr-2062 Backporting merged PR #2062 into main
🤖 @patchback |
Thank you very much for merging this PR, I was a bit busy and couldn't respond on time. |
…le-collections#2062) SUMMARY https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-configure.html#object-lock-configure-set-retention-period-object Design detail: AWS API doesn't support unsetting the default retention, though it is possible in the Web console. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves <[email protected]> (cherry picked from commit c2e7aaf)
#2177) SUMMARY https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-configure.html#object-lock-configure-set-retention-period-object Design detail: AWS API doesn't support unsetting the default retention, though it is possible in the Web console. ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket Reviewed-by: Helen Bailey [email protected] Reviewed-by: Alina Buzachis Reviewed-by: Mike Graves [email protected] (cherry picked from commit c2e7aaf) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mike Graves <[email protected]> Reviewed-by: GomathiselviS
SUMMARY
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock-configure.html#object-lock-configure-set-retention-period-object
Design detail:
AWS API doesn't support unsetting the default retention, though it is possible in the Web console.
ISSUE TYPE
COMPONENT NAME
s3_bucket