[PR #1956/470ca0a0 backport][stable-7] module_utils/elbv2 - fix issue with authenticate-oidc listener rule #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…1956) module_utils/elbv2 - fix issue with authenticate-oidc listener rule SUMMARY fixes #1877 The module now detect rule which changing priority, they are no more considered as new rules but we are using the set_rule_priorities API instead to update the priority. For authenticated-oidc rule, we set always set the UseExistingSecret to False for new rule to create and when the rule need to be modified and the user has provided a ClientSecret. ISSUE TYPE Bugfix Pull Request Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: Bikouo Aubin Reviewed-by: Alina Buzachis (cherry picked from commit 470ca0a)
alinabuzachis
approved these changes
Mar 1, 2024
abikouo
approved these changes
Mar 1, 2024
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 13s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-7/470ca0a0f5aef94a1fa7439bfc3566aac9871337/pr-1956
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1956 as merged into main (470ca0a).
SUMMARY
fixes #1877
The module now detect rule which changing priority, they are no more considered as new rules but we are using the
set_rule_prioritiesAPI instead to update the priority.For
authenticated-oidcrule, we set always set theUseExistingSecrettoFalsefor new rule to create and when the rule need to be modified and the user has provided aClientSecret.ISSUE TYPE