ec2_snapshot - stability - relax integration tests #1322

tremble · 2023-01-05T16:55:33Z

SUMMARY

When using pagination, you're not guaranteed to get "max_items", it's a maximum. Sometimes you'll get less. Relax the ec2_snapshot tests a little to take this into account.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_snapshot

ADDITIONAL INFORMATION

ansibullbot · 2023-01-05T17:05:21Z

cc @jillr @s-hertel @willthames
click here for bot help

softwarefactory-project-zuul · 2023-01-05T18:58:30Z

Build succeeded.

softwarefactory-project-zuul · 2023-01-09T11:28:25Z

Build succeeded (gate pipeline).

patchback · 2023-01-09T11:28:30Z

Backport to stable-4: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply ab5dfa1 on top of patchback/backports/stable-4/ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4/pr-1322

Backporting merged PR #1322 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-4/ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4/pr-1322 upstream/stable-4

Now, cherry-pick PR ec2_snapshot - stability - relax integration tests #1322 contents into that branch:
```
$ git cherry-pick -x ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4
```
If it'll yell at you with something like fatal: Commit ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4 is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR ec2_snapshot - stability - relax integration tests #1322 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-4/ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4/pr-1322

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2023-01-09T11:28:35Z

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply ab5dfa1 on top of patchback/backports/stable-5/ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4/pr-1322

Backporting merged PR #1322 into main

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/stable-5/ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4/pr-1322 upstream/stable-5

Now, cherry-pick PR ec2_snapshot - stability - relax integration tests #1322 contents into that branch:
```
$ git cherry-pick -x ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4
```
If it'll yell at you with something like fatal: Commit ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4 is a merge but no -m option was given., add -m 1 as follows intead:
```
$ git cherry-pick -m1 -x ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR ec2_snapshot - stability - relax integration tests #1322 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/stable-5/ab5dfa140d0cc79bccecfb8633f564a27fb2d9a4/pr-1322

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Bulk update imports after reshuffle Depends-On: #1323 Depends-On: #1322 Depends-On: #1321 SUMMARY module_utils code got split up. Bulk update the imports to reflect this ISSUE TYPE Feature Pull Request COMPONENT NAME various ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>

…nsible-collections#1322) route53_info: Add snake_cased return key,values to remaining methods SUMMARY Following up on ansible-collections#1236 Found more places where route53_info module does not return a snake_case output. Added snake_case output to checker_ip_range_details , reusable_delegation_set_details, and get_health_check methods. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None>

ec2_snapshot - stability relax tests

2febfa8

tremble requested a review from alinabuzachis January 5, 2023 16:55

tremble marked this pull request as ready for review January 5, 2023 16:55

ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration needs_triage plugins plugin (any type) tests tests labels Jan 5, 2023

tremble mentioned this pull request Jan 6, 2023

Bulk update imports after reshuffle #1310

Merged

tremble added backport-4 PR should be backported to the stable-4 branch backport-5 PR should be backported to the stable-5 branch labels Jan 9, 2023

alinabuzachis approved these changes Jan 9, 2023

View reviewed changes

tremble added the mergeit Merge the PR (SoftwareFactory) label Jan 9, 2023

softwarefactory-project-zuul bot merged commit ab5dfa1 into ansible-collections:main Jan 9, 2023

tremble mentioned this pull request Feb 6, 2023

ec2_snapshot - tests unstable #441

Closed

1 task

tremble deleted the tests/stability/ec2_snapshots branch February 15, 2023 09:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ec2_snapshot - stability - relax integration tests #1322

ec2_snapshot - stability - relax integration tests #1322

tremble commented Jan 5, 2023

ansibullbot commented Jan 5, 2023

softwarefactory-project-zuul bot commented Jan 5, 2023

softwarefactory-project-zuul bot commented Jan 9, 2023

patchback bot commented Jan 9, 2023 •

edited

Loading

patchback bot commented Jan 9, 2023 •

edited

Loading

ec2_snapshot - stability - relax integration tests #1322

ec2_snapshot - stability - relax integration tests #1322

Conversation

tremble commented Jan 5, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Jan 5, 2023

softwarefactory-project-zuul bot commented Jan 5, 2023

softwarefactory-project-zuul bot commented Jan 9, 2023

patchback bot commented Jan 9, 2023 • edited Loading

Backport to stable-4: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1322 into main

patchback bot commented Jan 9, 2023 • edited Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

Backporting merged PR #1322 into main

patchback bot commented Jan 9, 2023 •

edited

Loading

patchback bot commented Jan 9, 2023 •

edited

Loading