Fixed rds inventory tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cancelled tests cause that just kicks off collections build workflow |
Remove aws_secret that gets duplicated in both collections by migrate.py
This WILL fail cause the import rewriting violates line length but I want the other tests to run
1 task
Closed
1 task
1 task
1 task
1 task
hakbailey
pushed a commit
that referenced
this pull request
Apr 3, 2024
* WIP - adding new functionality to aws_s3_bucket_info module * Fixing exceptions adding integration tests * Code linting - shippable * Fixing option type * Fixing RETURN / Shippable * Sync with upstream + .gitignore VSCode * Extending integration test * Adding version_added to new module options * Prepare 1.3.0 changelog * Use boto3_tag_list_to_ansible_dict for bucket tags * Fixing integration test (delete buckets) * Adjust integration test (python 2.7) * fix integratiuon test -2 * Adjusting changelogs/changelog.yaml * WIP - adding new functionality to aws_s3_bucket_info module * Fixing exceptions adding integration tests * Code linting - shippable * Fixing option type * Fixing RETURN / Shippable * Extending integration test * Adding version_added to new module options * Prepare 1.3.0 changelog * Use boto3_tag_list_to_ansible_dict for bucket tags * Fixing integration test (delete buckets) * Adjust integration test (python 2.7) * fix integratiuon test -2 * Adjusting changelogs/changelog.yaml * WIP - adding new functionality to aws_s3_bucket_info module * Fixing exceptions adding integration tests * Code linting - shippable * Fixing option type * Fixing RETURN / Shippable * Extending integration test * Adding version_added to new module options * Use boto3_tag_list_to_ansible_dict for bucket tags * Fixing integration test (delete buckets) * Adjust integration test (python 2.7) * fix integratiuon test -2 * WIP - adding new functionality to aws_s3_bucket_info module * Fixing exceptions adding integration tests * Code linting - shippable * Fixing option type * Fixing RETURN / Shippable * Extending integration test * Adding version_added to new module options * Use boto3_tag_list_to_ansible_dict for bucket tags * Fixing integration test (delete buckets) * Adjust integration test (python 2.7) * fix integratiuon test -2 * Merging requested PR changes #1 Co-authored-by: Mark Chappell <[email protected]> * Bump version_added 1.3.0->1.4.0 Co-authored-by: Mark Chappell <[email protected]> * Fix module docstring Co-authored-by: Mark Chappell <[email protected]> * Fixing changelog * Code cleanup * Update integration tests * Add S3 bucket location check to integration test * Documentation update - fix wording and typos in DOCUMENTATION - complete rewrite of RETURN * Update plugins/modules/aws_s3_bucket_info.py * Update plugins/modules/aws_s3_bucket_info.py * Fixing RETURN indentation * Fixing missing type: in RETURN * Revert changes to changelogs/changelog.yaml * Revert changes to changelogs/changelog.yaml Co-authored-by: Mark Chappell <[email protected]>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 22, 2024
…ats (#2080) [Part #1]: Ensures the modules documentation follows the correct formats SUMMARY Ensures the modules documentation follows the correct formats https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#semantic-markup-within-module-documentation More PRs are yet to come ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Bikouo Aubin
patchback bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…ats (#2080) [Part #1]: Ensures the modules documentation follows the correct formats SUMMARY Ensures the modules documentation follows the correct formats https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#semantic-markup-within-module-documentation More PRs are yet to come ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Bikouo Aubin (cherry picked from commit 574cb86)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…ats (#2080) (#2243) This is a backport of PR #2080 as merged into main (574cb86). SUMMARY Ensures the modules documentation follows the correct formats https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html#semantic-markup-within-module-documentation More PRs are yet to come ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
test shippable on aws core collection for a pr
ISSUE TYPE
COMPONENT NAME
inventory_rds_plugin