Create application now returns the key value in a struct with the ID #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added UpdateApplication function to allow updating of application name and description |
0x4c6565
requested changes
Aug 16, 2024
| return body.Data.ID, err | ||
| } | ||
|
|
||
| func (s *Service) createApplicationResponseBody(req CreateApplicationRequest) (*connection.APIResponseBodyData[Application], error) { | ||
| return connection.Post[Application](s.connection, "/account/v1/applications", &req) | ||
| func (s *Service) updateApplicationResponseBody(req CreateApplicationRequest) (*connection.APIResponseBodyData[Application], error) { |
There was a problem hiding this comment.
You're accepting req CreateApplicationRequest for update here
| body, err := s.createApplicationResponseBody(req) | ||
|
|
||
| response := CreateApplicationResponse{ |
There was a problem hiding this comment.
Rather than create a new response here, you can just return body.Data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create application wasn't previously returning the key for the API key created, needed for terraform provider