Skip to content

Commit

Permalink
Merge pull request #8 from ukfast/renametemplaterequest-property-fix
Browse files Browse the repository at this point in the history
fix RenameTemplateRequest to use correct properties
  • Loading branch information
0x4c6565 authored Mar 26, 2019
2 parents b68e654 + a2ecc9b commit c44d2b9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions pkg/service/ecloud/request.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ func (c *PatchSolutionRequest) Validate() *connection.ValidationError {
type RenameTemplateRequest struct {
connection.APIRequestBodyDefaultValidator

NewTemplateName string `json:"new_template_name" validate:"required"`
SolutionID *int `json:"solution_id,omitempty"`
Destination string `json:"destination" validate:"required"`
}

// Validate returns an error if struct properties are missing/invalid
Expand Down
2 changes: 1 addition & 1 deletion pkg/service/ecloud/request_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func TestPatchSolutionRequest_Validate_NoError(t *testing.T) {
func TestRenameTemplateRequest_Validate(t *testing.T) {
t.Run("Valid_NoError", func(t *testing.T) {
c := RenameTemplateRequest{
NewTemplateName: "testtemplate1",
Destination: "testtemplate1",
}

err := c.Validate()
Expand Down
2 changes: 1 addition & 1 deletion pkg/service/ecloud/service_solution_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1524,7 +1524,7 @@ func TestRenameSolutionTemplate(t *testing.T) {
}

expectedRequest := RenameTemplateRequest{
NewTemplateName: "testname2",
Destination: "testname2",
}

c.EXPECT().Post("/ecloud/v1/solutions/123/templates/testname1/move", gomock.Eq(&expectedRequest)).Return(&connection.APIResponse{
Expand Down

0 comments on commit c44d2b9

Please sign in to comment.