ledger: improve genesis flow

.changelog/unreleased/features/870-pre-genesis-wallet.md

@@ -0,0 +1,6 @@
+- Added `--pre-genesis` argument to the wallet commands to allow to generate
+  keys, implicit addresses and shielded keys without having a chain setup. If
+  no chain is setup yet (i.e. there's no base-dir `.namada` or it's empty), the
+  wallet defaults to use the pre-genesis wallet even without the `--pre-genesis`
+  flag. The pre-genesis wallet is located in `.namada/pre-genesis/wallet.toml`.
+  ([#870](https://github.com/anoma/namada/pull/870))

.changelog/unreleased/improvements/849-human-readable-string-encoding.md

@@ -0,0 +1,2 @@
+- Added bech32m string encoding for `common::PublicKey` and `DkgPublicKey`.
+  ([#849](https://github.com/anoma/namada/pull/849))

Makefile

@@ -23,13 +23,13 @@ build-test:
 	$(cargo) build --tests
 
 build-release:
-	NAMADA_DEV=false $(cargo) build --release --package namada_apps --manifest-path Cargo.toml
+	$(cargo) build --release --package namada_apps --manifest-path Cargo.toml
 
 install-release:
-	NAMADA_DEV=false $(cargo) install --path ./apps --locked
+	$(cargo) install --path ./apps --locked
 
 check-release:
-	NAMADA_DEV=false $(cargo) check --release --package namada_apps
+	$(cargo) check --release --package namada_apps
 
 package: build-release
 	scripts/make-package.sh
@@ -55,13 +55,13 @@ check-mainnet:
 clippy-wasm = $(cargo) +$(nightly) clippy --manifest-path $(wasm)/Cargo.toml --all-targets -- -D warnings
 
 clippy:
-	NAMADA_DEV=false $(cargo) +$(nightly) clippy --all-targets -- -D warnings && \
+	$(cargo) +$(nightly) clippy --all-targets -- -D warnings && \
 	make -C $(wasms) clippy && \
 	make -C $(wasms_for_tests) clippy && \
 	$(foreach wasm,$(wasm_templates),$(clippy-wasm) && ) true
 
 clippy-abcipp:
-	NAMADA_DEV=false $(cargo) +$(nightly) clippy --all-targets \
+	$(cargo) +$(nightly) clippy --all-targets \
 		--manifest-path ./apps/Cargo.toml \
 		--no-default-features \
 		--features "std testing abcipp" && \
@@ -86,7 +86,7 @@ clippy-fix:
 	$(cargo) +$(nightly) clippy --fix -Z unstable-options --all-targets --allow-dirty --allow-staged
 
 install: tendermint
-	NAMADA_DEV=false $(cargo) install --path ./apps --locked
+	$(cargo) install --path ./apps --locked
 
 tendermint:
 	./scripts/get_tendermint.sh

README.md

@@ -48,10 +48,6 @@ Guide.
 ```shell
 # Build the provided validity predicate and transaction wasm modules
 make build-wasm-scripts-docker
-
-# Development (debug) build Namada, which includes a validator and some default 
-# accounts, whose keys and addresses are available in the wallet
-NAMADA_DEV=true make
 ```
 
 ### Before submitting a PR, pls make sure to run the following

apps/Cargo.toml

@@ -44,10 +44,9 @@ default = ["std", "abciplus"]
 mainnet = [
   "namada/mainnet",
 ]
-dev = ["namada/dev"]
 std = ["ed25519-consensus/std", "rand/std", "rand_core/std"]
 # for integration tests and test utilies
-testing = ["dev"]
+testing = []
 
 abcipp = [
     "namada/abcipp",
@@ -155,6 +154,7 @@ rust_decimal_macros = "1.26.1"
 [dev-dependencies]
 namada = {path = "../shared", default-features = false, features = ["testing", "wasm-runtime"]}
 bit-set = "0.5.2"
+pretty_assertions = "1.3.0"
 # A fork with state machime testing
 proptest = {git = "https://github.com/heliaxdev/proptest", branch = "tomas/sm"}
 tempfile = "3.2.0"

apps/build.rs

@@ -53,13 +53,4 @@ fn main() {
 
     // Tell Cargo that if the given file changes, to rerun this build script.
     println!("cargo:rerun-if-changed={}", PROTO_SRC);
-
-    // Tell Cargo to build when the `NAMADA_DEV` env var changes
-    println!("cargo:rerun-if-env-changed=NAMADA_DEV");
-    // Enable "dev" feature if `NAMADA_DEV` is trueish
-    if let Ok(dev) = env::var("NAMADA_DEV") {
-        if dev.to_ascii_lowercase().trim() == "true" {
-            println!("cargo:rustc-cfg=feature=\"dev\"");
-        }
-    }
 }

apps/src/bin/namada-client/cli.rs

@@ -111,6 +111,12 @@ pub async fn main() -> Result<()> {
             Utils::InitGenesisValidator(InitGenesisValidator(args)) => {
                 utils::init_genesis_validator(global_args, args)
             }
+            Utils::ValidateGenesisTemplates(ValidateGenesisTemplates(args)) => {
+                utils::validate_genesis_templates(global_args, args)
+            }
+            Utils::SignGenesisTx(SignGenesisTx(args)) => {
+                utils::sign_genesis_tx(global_args, args)
+            }
         },
     }
     Ok(())

apps/src/bin/namada-node/cli.rs

@@ -8,12 +8,15 @@ use namada_apps::node::ledger;
 pub fn main() -> Result<()> {
     let (cmd, mut ctx) = cli::namada_node_cli()?;
     if let Some(mode) = ctx.global_args.mode.clone() {
-        ctx.config.ledger.tendermint.tendermint_mode = mode;
+        if let Some(chain) = ctx.chain.as_mut() {
+            chain.config.ledger.tendermint.tendermint_mode = mode;
+        }
     }
     match cmd {
         cmds::NamadaNode::Ledger(sub) => match sub {
             cmds::Ledger::Run(cmds::LedgerRun(args)) => {
-                let wasm_dir = ctx.wasm_dir();
+                let chain_ctx = ctx.take_chain_or_exit();
+                let wasm_dir = chain_ctx.wasm_dir();
 
                 // Sleep until start time if needed
                 if let Some(time) = args.0 {
@@ -31,14 +34,16 @@ pub fn main() -> Result<()> {
                         }
                     }
                 }
-                ledger::run(ctx.config.ledger, wasm_dir);
+                ledger::run(chain_ctx.config.ledger, wasm_dir);
             }
             cmds::Ledger::Reset(_) => {
-                ledger::reset(ctx.config.ledger)
+                let chain_ctx = ctx.take_chain_or_exit();
+                ledger::reset(chain_ctx.config.ledger)
                     .wrap_err("Failed to reset Namada node")?;
             }
             cmds::Ledger::DumpDb(cmds::LedgerDumpDb(args)) => {
-                ledger::dump_db(ctx.config.ledger, args);
+                let chain_ctx = ctx.take_chain_or_exit();
+                ledger::dump_db(chain_ctx.config.ledger, args);
             }
         },
         cmds::NamadaNode::Config(sub) => match sub {
@@ -47,18 +52,18 @@ pub fn main() -> Result<()> {
                 // In here, we just need to overwrite the default chain ID, in
                 // case it's been already set to a different value
                 if let Some(chain_id) = ctx.global_args.chain_id.as_ref() {
-                    ctx.global_config.default_chain_id = chain_id.clone();
+                    ctx.global_config.default_chain_id = Some(chain_id.clone());
                     ctx.global_config
                         .write(&ctx.global_args.base_dir)
                         .unwrap_or_else(|err| {
-                            eprintln!("Error writing global config: {}", err);
+                            eprintln!("Error writing global config: {err}");
                             cli::safe_exit(1)
                         });
+                    tracing::debug!(
+                        "Generated config and set default chain ID to \
+                         {chain_id}"
+                    );
                 }
-                tracing::debug!(
-                    "Generated config and set default chain ID to {}",
-                    &ctx.global_config.default_chain_id
-                );
             }
         },
     }