Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crates build with some non-default features (backport #4403) #4405

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 21, 2025

Describe your changes

In #4401 it was found that some crates released in 0.47.2 fail to build with certain features. To be able to run #4401 check reliably the baseline (i.e. last release it's comparing the API with) has to be fixed first.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

This is an automatic backport of pull request #4403 done by [Mergify](https://mergify.com).

@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Feb 21, 2025
@mergify mergify bot merged commit c94beee into maint-libs-0.47 Feb 21, 2025
15 of 16 checks passed
@mergify mergify bot deleted the mergify/bp/maint-libs-0.47/pr-4403 branch February 21, 2025 11:58
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (68ddf61) to head (4c17ccf).
Report is 6 commits behind head on maint-libs-0.47.

Additional details and impacted files
@@               Coverage Diff                @@
##           maint-libs-0.47    #4405   +/-   ##
================================================
  Coverage            74.53%   74.53%           
================================================
  Files                  339      339           
  Lines               110504   110504           
================================================
+ Hits                 82363    82367    +4     
+ Misses               28141    28137    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant