Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less permissive VPs #2213

Merged
merged 10 commits into from
Dec 29, 2023
3 changes: 3 additions & 0 deletions .changelog/unreleased/improvements/2213-vp-less-permissive.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- The default implicit and established user account VPs now
require valid signature(s) for unknown storage changes.
([\#2213](https://github.com/anoma/namada/pull/2213))
5 changes: 2 additions & 3 deletions benches/vps.rs
Original file line number Diff line number Diff line change
Expand Up @@ -182,8 +182,7 @@ fn vp_implicit(c: &mut Criterion) {
.try_to_sk()
.unwrap();

let foreign_key_write =
generate_foreign_key_tx(&defaults::albert_keypair());
let foreign_key_write = generate_foreign_key_tx(&implicit_account);

let shell = BenchShell::default();
let transfer = shell.generate_tx(
Expand Down Expand Up @@ -327,7 +326,7 @@ fn vp_validator(c: &mut Criterion) {
let mut group = c.benchmark_group("vp_validator");

let foreign_key_write =
generate_foreign_key_tx(&defaults::albert_keypair());
generate_foreign_key_tx(&defaults::validator_keypair());

let transfer = shell.generate_tx(
TX_TRANSFER_WASM,
Expand Down
2 changes: 2 additions & 0 deletions core/src/types/address.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ pub const POS_SLASH_POOL: Address =
pub const GOV: Address = Address::Internal(InternalAddress::Governance);
/// Internal MASP address
pub const MASP: Address = Address::Internal(InternalAddress::Masp);
/// Internal Multitoken address
pub const MULTITOKEN: Address = Address::Internal(InternalAddress::Multitoken);

/// Error from decoding address from string
pub type DecodeError = string_encoding::DecodeError;
Expand Down
1 change: 1 addition & 0 deletions core/src/types/ibc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ use crate::ibc::apps::transfer::types::{Memo, PrefixedDenom, TracePath};
use crate::ibc::core::handler::types::events::{
Error as IbcEventError, IbcEvent as RawIbcEvent,
};
pub use crate::ledger::ibc::storage::is_ibc_key;
use crate::tendermint::abci::Event as AbciEvent;
use crate::types::masp::PaymentAddress;

Expand Down
Loading