Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch the Ethereum bridge design to use Tendermint v0.38 + ABCI++ #198

Open
james-chf opened this issue Jul 19, 2022 · 1 comment
Open

Switch the Ethereum bridge design to use Tendermint v0.38 + ABCI++ #198

james-chf opened this issue Jul 19, 2022 · 1 comment
Labels
ABCI++ This issue should be done when we switch to ABCI++ (Tendermint v0.38) client ethereum-bridge ledger post-mainnet Don't worry about this yet.

Comments

@james-chf
Copy link
Contributor

james-chf commented Jul 19, 2022 •
edited
Loading

For initial launch of the Ethereum bridge, we will be using ABCI 0.18 from Tendermint v0.37, which only gives us PrepareProposal/ProcessProposal ABCI methods. We eventually want to switch to Tendermint v0.38 and ABCI 0.19 which will let us properly use vote extensions. We have some code in the codebase to do with this Tendermint v0.38 design, guarded behind the abcipp feature flag.

We probably shouldn't attempt this until there is a stable prerelease of Tendermint v0.38 available for us to develop against.

Issues related to doing this are labelled ABCI++ This issue should be done when we switch to ABCI++ (Tendermint v0.38)

@james-chf james-chf added enhancement New feature or request ethereum-bridge labels Jul 19, 2022
@james-chf james-chf moved this to Todo in Namada-Old Jul 19, 2022
@james-chf james-chf changed the title Switch to ABCI++ Switch to ABCI++ instead of ABCI Jul 19, 2022
@batconjurer batconjurer moved this from Todo to WIP in Namada-Old Aug 15, 2022
@james-chf
Copy link
Contributor Author

We will be using ABCI v0.18.0 (i.e. parts of the former ABCI++) for initial Namada release but would eventually like to switch to ABCI v0.19.0 (full ABCI++) later on to support things like Ferveo and a better Ethereum bridge implementation

@james-chf james-chf moved this from WIP to Todo in Namada-Old Aug 24, 2022
@tzemanovic tzemanovic moved this from Todo to WIP in Namada-Old Aug 30, 2022
@james-chf james-chf added ethereum-bridge and removed enhancement New feature or request labels Sep 27, 2022
@james-chf james-chf moved this from WIP to Todo in Namada-Old Sep 27, 2022
@james-chf james-chf changed the title Switch to ABCI++ instead of ABCI Switch the Ethereum bridge design to use Tendermint v0.38 ABCI++ Sep 27, 2022
@james-chf james-chf moved this from Todo to Low-prio in Namada-Old Sep 27, 2022
@james-chf james-chf assigned james-chf and unassigned james-chf Oct 14, 2022
@james-chf james-chf mentioned this issue Dec 8, 2022
Merged
@james-chf james-chf added the ABCI++ This issue should be done when we switch to ABCI++ (Tendermint v0.38) label Jan 12, 2023
@james-chf james-chf changed the title Switch the Ethereum bridge design to use Tendermint v0.38 ABCI++ Switch the Ethereum bridge design to use Tendermint v0.38 + ABCI++ Jan 12, 2023
@cwgoes cwgoes added the post-mainnet Don't worry about this yet. label May 26, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@mateuszjasiuk
feat: Sdk integration (anoma#198)
1d1a217 
* feat: test sdk extension

* feat: temporary remove masp stuff

* feat: WIP bond tx with wasm

* fix: fetch using sdk

* feat: bond tx using sdk

* fix: submitBond return value

* feat: store first created accounts in the sdk storage

* feat: Change SubmitBondMsg to take single msg argument

* feat: cleanup extern fetch call

* feat: get ledger address from the env

* fix: some of the error handling

* fix: store to presist spending keys

* feat: reset transfer masp changes

* feat: remove api.rs

* fix: my validators to only get non shielded addresses

* feat: use sdk for transparent transfer tx (anoma#204)

* refactor: use amountToMicro

* feat: pass password to add_keys and add_secret_key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ABCI++ This issue should be done when we switch to ABCI++ (Tendermint v0.38) client ethereum-bridge ledger post-mainnet Don't worry about this yet.
Projects
No open projects
Namada-Old
Status: Low-prio
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwgoes @james-chf