Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoS - consider removing "votes_per_token" param and use token directly #159

Closed
tzemanovic opened this issue Jul 6, 2022 · 1 comment
Closed
Labels

Comments

@tzemanovic
Copy link
Member

tzemanovic commented Jul 6, 2022

The votes_per_token PoS system parameter must be chosen to satisfy the Tendermint requirement of MaxTotalVotingPower = MaxInt64 / 8. - This implies that with if we were to remove votes_per_token, with our u64 token representation of micro units, the total supply of the native token would be capped at 1 152 921 504 606 (i64::MAX / 10^6 / 8). Because the votes_per_token conversion is currently lossy, the PoS tracks voting power separately from total stake often we have to recalculate the voting power from stake, so getting rid of it would simplify handling of validator voting power and validator sets that depend on it.

@tzemanovic
Copy link
Member Author

closed in favour of #455

@tzemanovic tzemanovic closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2022
Repository owner moved this from Todo to Tested in Devnet in Namada-Old Sep 9, 2022
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Tested in Devnet
Development

No branches or pull requests

1 participant