Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out test-related functionality from anomac utils init-network #115

Closed
james-chf opened this issue May 19, 2022 · 3 comments · Fixed by #2088
Closed

Split out test-related functionality from anomac utils init-network #115

james-chf opened this issue May 19, 2022 · 3 comments · Fixed by #2088

Comments

@james-chf
Copy link
Contributor

james-chf commented May 19, 2022

Building on the functionality coming in anoma/anoma#1053

When anomac utils init-network --chain-id $CHAIN is run on a network configuration file (e.g. namada-cq-1.toml, it creates a .anoma/$CHAIN/setup directory with a subdirectory for each genesis validator containing generated files. This is mostly useful in e2e tests where we want to generate keys for the disposable validator nodes used in tests. For production use where genesis validators should generate keys themselves using anomac utils init-genesis-validator, nothing should be generated here.

We should find a way to split out the test-related functionality from the anoma_app::client::utils::init_network function e.g. we could have a init_test_network function which keeps the current functionality of generating private keys if they are missing, and init_network could instead start warning if things needed for a real network weren't present.

@tzemanovic
Copy link
Member

maybe this could be a flag for init-network something like --gen-missing and when it's not specified and something is missing, it could exit with some validation error. This is also useful for devnet/testnet deployment

@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@cwgoes
Copy link
Collaborator

cwgoes commented Jan 13, 2023

@tzemanovic is this still relevant?

@tzemanovic
Copy link
Member

@tzemanovic is this still relevant?

yes, but I think this will be solved in #685 that is using different approach for how genesis is setup - init-network doesn't generate any keys anymore. I'll link it to the PR

@batconjurer batconjurer mentioned this issue Nov 3, 2023
2 tasks
@github-project-automation github-project-automation bot moved this from Todo to Tested in Devnet in Namada-Old Nov 5, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Tested in Devnet
3 participants