address clippy warnings

apps/src/bin/namada-client/cli.rs

@@ -10,7 +10,6 @@ use namada_apps::client::{rpc, tx, utils};
 use namada_apps::facade::tendermint::block::Height;
 use namada_apps::facade::tendermint_config::net::Address as TendermintAddress;
 use namada_apps::facade::tendermint_rpc::{Client, HttpClient};
-use namada_apps::wallet::CliWalletUtils;
 use tokio::time::sleep;
 
 pub async fn main() -> Result<()> {

apps/src/lib/cli.rs

@@ -1696,7 +1696,7 @@ pub mod args {
         "base-dir",
         DefaultFn(|| match env::var("NAMADA_BASE_DIR") {
             Ok(dir) => PathBuf::from(dir),
-            Err(_) => PathBuf::from(config::get_default_namada_folder()),
+            Err(_) => config::get_default_namada_folder(),
         }),
     );
     pub const BLOCK_HEIGHT: Arg<BlockHeight> = arg("block-height");

apps/src/lib/client/rpc.rs

@@ -85,7 +85,7 @@ pub async fn query_block<C: namada::ledger::queries::Client + Sync>(
 /// Query the results of the last committed block
 pub async fn query_results<C: namada::ledger::queries::Client + Sync>(
     client: &C,
-    args: args::Query,
+    _args: args::Query,
 ) -> Vec<BlockResults> {
     unwrap_client_response::<C, Vec<BlockResults>>(
         RPC.shell().read_results(client).await,
@@ -414,7 +414,7 @@ pub async fn query_pinned_balance<
                 // Extract and print only the specified token from the total
                 let (_asset_type, balance) =
                     value_by_address(&balance, token.clone(), epoch);
-                let token_alias = lookup_alias(wallet, &token);
+                let token_alias = lookup_alias(wallet, token);
                 if balance == 0 {
                     println!(
                         "Payment address {} was consumed during epoch {}. \
@@ -1250,7 +1250,7 @@ pub async fn query_withdrawable_tokens<
 /// Query PoS bond(s) and unbond(s)
 pub async fn query_bonds<C: namada::ledger::queries::Client + Sync>(
     client: &C,
-    wallet: &mut Wallet<CliWalletUtils>,
+    _wallet: &mut Wallet<CliWalletUtils>,
     args: args::QueryBonds,
 ) -> std::io::Result<()> {
     let _epoch = query_and_print_epoch(client).await;
@@ -1448,7 +1448,7 @@ pub async fn query_and_print_commission_rate<
     C: namada::ledger::queries::Client + Sync,
 >(
     client: &C,
-    wallet: &mut Wallet<CliWalletUtils>,
+    _wallet: &mut Wallet<CliWalletUtils>,
     args: args::QueryCommissionRate,
 ) {
     let validator = args.validator;
@@ -1480,7 +1480,7 @@ pub async fn query_and_print_commission_rate<
 /// Query PoS slashes
 pub async fn query_slashes<C: namada::ledger::queries::Client + Sync>(
     client: &C,
-    wallet: &mut Wallet<CliWalletUtils>,
+    _wallet: &mut Wallet<CliWalletUtils>,
     args: args::QuerySlashes,
 ) {
     let params_key = pos::params_key();
@@ -1545,7 +1545,7 @@ pub async fn query_slashes<C: namada::ledger::queries::Client + Sync>(
 
 pub async fn query_delegations<C: namada::ledger::queries::Client + Sync>(
     client: &C,
-    wallet: &mut Wallet<CliWalletUtils>,
+    _wallet: &mut Wallet<CliWalletUtils>,
     args: args::QueryDelegations,
 ) {
     let owner = args.owner;

apps/src/lib/client/signing.rs

@@ -7,11 +7,10 @@ use namada::ledger::tx;
 use namada::ledger::wallet::{Wallet, WalletUtils};
 use namada::proto::Tx;
 use namada::types::address::Address;
-use namada::types::hash::Hash;
 use namada::types::key::*;
 use namada::types::storage::Epoch;
 
-use crate::cli::{args, Context};
+use crate::cli::{args};
 
 /// Find the public key for the given address and try to load the keypair
 /// for it from the wallet. Panics if the key cannot be found or loaded.

apps/src/lib/client/tx.rs

@@ -11,7 +11,7 @@ use borsh::{BorshDeserialize, BorshSerialize};
 use data_encoding::HEXLOWER_PERMISSIVE;
 use masp_proofs::prover::LocalTxProver;
 use namada::ledger::governance::storage as gov_storage;
-use namada::ledger::masp::{ShieldedContext, ShieldedUtils};
+
 use namada::ledger::rpc::{TxBroadcastData, TxResponse};
 use namada::ledger::signing::TxSigningKey;
 use namada::ledger::wallet::{Wallet, WalletUtils};
@@ -92,7 +92,7 @@ pub async fn submit_init_validator<
         max_commission_rate_change,
         validator_vp_code_path,
         unsafe_dont_encrypt,
-        tx_code_path,
+        tx_code_path: _,
     }: args::TxInitValidator,
 ) {
     let tx_args = args::Tx {

apps/src/lib/wallet/mod.rs

@@ -55,8 +55,8 @@ impl WalletUtils for CliWalletUtils {
     }
 
     fn show_overwrite_confirmation(
-        alias: &Alias,
-        alias_for: &str,
+        _alias: &Alias,
+        _alias_for: &str,
     ) -> ConfirmationResponse {
         ConfirmationResponse::Replace
     }

apps/src/lib/wallet/store.rs

@@ -2,16 +2,16 @@ use std::fs;
 use std::io::prelude::*;
 use std::io::Write;
 use std::path::{Path, PathBuf};
-use std::str::FromStr;
+
 
 use ark_std::rand::prelude::*;
 use ark_std::rand::SeedableRng;
 use file_lock::{FileLock, FileOptions};
-use namada::ledger::wallet::store::AddressVpType;
+
 #[cfg(feature = "dev")]
 use namada::ledger::wallet::StoredKeypair;
 use namada::ledger::wallet::{gen_sk, Store, ValidatorKeys};
-use namada::types::address::Address;
+
 use namada::types::key::*;
 use namada::types::transaction::EllipticCurve;
 use thiserror::Error;