Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Core parser error handling #3300

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Improve Core parser error handling #3300

wants to merge 7 commits into from

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Jan 30, 2025 •
edited
Loading

  • Use CoreError for errors unrelated to parsing proper (e.g. scoping errors like undeclared identifier)
  • Adds negative parsing tests
  • Fixes parsing of side-conditions in match branches
  • Fixes a bug in redundant pattern detection with side-conditions

@lukaszcz lukaszcz added error-messaging core Related to JuvixCore labels Jan 30, 2025
@lukaszcz lukaszcz added this to the 0.6.10 milestone Jan 30, 2025
@lukaszcz lukaszcz self-assigned this Jan 30, 2025
@lukaszcz lukaszcz marked this pull request as ready for review January 30, 2025 19:18
@lukaszcz lukaszcz marked this pull request as draft January 31, 2025 09:04
@lukaszcz lukaszcz marked this pull request as ready for review January 31, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira Awaiting requested review from janmasrovira

@paulcadman paulcadman Awaiting requested review from paulcadman

At least 1 approving review is required to merge this pull request.

Assignees

@lukaszcz lukaszcz

Labels
core Related to JuvixCore error-messaging
Projects
None yet
Milestone
0.6.10
Development

Successfully merging this pull request may close these issues.
1 participant
@lukaszcz