Give proper colors to builtins #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
changed the title
janmasrovira
changed the title
paulcadman
approved these changes
Jun 18, 2024
janmasrovira
deleted the
2800-builtin-axioms-should-have-a-different-face-color-than-non-builtin-axioms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a field
_nameKindPretty :: NameKindthat is used to store the nameKind which should be used when highlighting and printing.There is no need for pragmas as we can set a color for each builtin axiom statically in the haskell code.
I've also removed the fields
_infoHighlightDoc :: DocTableand_infoHighlightNames :: [S.AName]from theStore/Scoped/Data/InfoTableas they were never being read.