Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report proper location for normalized types in the WrongType error #2814

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

janmasrovira
Copy link
Collaborator

@janmasrovira janmasrovira commented Jun 7, 2024

There is currently no automated way to test this. One can manually check that when trying to typecheck tests/negative/issue2771/Main.juvix/ the error location is wrong:
image

That is now fixed:
image

@janmasrovira janmasrovira self-assigned this Jun 7, 2024
@janmasrovira janmasrovira changed the title Strong normalize keep location Keep source location when normalizing Jun 7, 2024
@janmasrovira janmasrovira force-pushed the strong-normalize-keep-location branch 3 times, most recently from 5d25940 to 042973e Compare June 7, 2024 16:42
@janmasrovira janmasrovira changed the title Keep source location when normalizing Report proper location for normalized types in the WrongType error Jun 7, 2024
@janmasrovira janmasrovira marked this pull request as ready for review June 7, 2024 16:51
@janmasrovira janmasrovira requested a review from lukaszcz June 8, 2024 06:55
@janmasrovira janmasrovira force-pushed the strong-normalize-keep-location branch 2 times, most recently from bf9ebb9 to a7590de Compare June 8, 2024 07:44
@janmasrovira janmasrovira force-pushed the strong-normalize-keep-location branch from a7590de to 95e1699 Compare June 8, 2024 09:19
@janmasrovira janmasrovira merged commit 2c683a1 into main Jun 8, 2024
4 checks passed
@janmasrovira janmasrovira deleted the strong-normalize-keep-location branch June 8, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants