Double substitute the Nockma functions placeholder in the main function #2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
funcs-lib-subst
branch
from
82b5bfa to
ee52d4b
Compare
First substitution is for the functionsLibrary placeholder in the main function, the second substitution is to subsitute the placeholders in the functions library.
paulcadman
force-pushed
the
funcs-lib-subst
branch
from
ee52d4b to
c913bd6
Compare
janmasrovira
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the nockma compilation backend we compile functions with a an atom with hint
functionsPlaceholderwhere the functions library is expected to be. After the module is compiled we now have the functions library to substitute.The first substitution replaces the
functionsPlaceholderin the main function with the functions library.This PR introduces a second substitution that replaces the
functionsPlaceholderatoms in the functions library that were introduced in the first subsitution.This fix is sufficient to get the transaction example running in the Anoma system.