Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field element type #2659

Merged
merged 22 commits into from
Feb 27, 2024
Merged

Add field element type #2659

merged 22 commits into from
Feb 27, 2024

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Feb 16, 2024

Checklist

  • Add field type and operations to intermediate representations (JuvixCore, JuvixTree, JuvixAsm, JuvixReg).
  • Add CLI option to choose field size.
  • Add frontend field builtins.
  • Automatic conversion of integer literals to field elements.
  • Juvix standard library support for fields.
  • Check if field size matches when loading a stored module.
  • Update the Cairo Assembly (CASM) interpreter to use the field type instead of integer type.
  • Add field type to VampIR backend.
  • Tests

@lukaszcz lukaszcz added the enhancement New feature or request label Feb 16, 2024
@lukaszcz lukaszcz added this to the 0.6.0 milestone Feb 16, 2024
@lukaszcz lukaszcz self-assigned this Feb 16, 2024
@lukaszcz lukaszcz mentioned this pull request Feb 26, 2024
7 tasks
@lukaszcz lukaszcz marked this pull request as ready for review February 26, 2024 14:30
package.yaml Outdated Show resolved Hide resolved
stack.yaml Outdated Show resolved Hide resolved
@lukaszcz lukaszcz requested a review from paulcadman February 26, 2024 15:43
Copy link
Collaborator

@janmasrovira janmasrovira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are only using finite-field for the FiniteField typeclass, I think it makes sense to also copy that definition into our codebase and drop the dependency. I've done that in #2673

@lukaszcz lukaszcz merged commit dcea0bb into main Feb 27, 2024
4 checks passed
@lukaszcz lukaszcz deleted the field-type branch February 27, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add field element type
3 participants