Reorganize telemetry monitor code into subpackage #12
Conversation
ankona
changed the title
| # it is possible to read the manifest prior to a completed | ||
| # write due to no access locking mechanism. log the issue | ||
| # and continue. it will retry on the next event loop iteration | ||
| manifest = RuntimeManifest.load_manifest(manifest_path) |
There was a problem hiding this comment.
In def process_manifest: you catch both a JSONDecodeError and a ValueError but return from the function, do you want to allow the program to continue if manifest.py raises a ValueError or JSONDecodeError?
There was a problem hiding this comment.
So far.... yes. The occurrence of these partial read/write issues has been pretty much non-existent, but they have occurred. I don't need to kill the telemetry monitor for it, I just need to let it wait to try reading the file again on the next iteration of the "event loop."
You might be thinking that I've set myself up for a forever-fail-loop by letting it just repeat attempts to read a bad file. This is totally a valid point, but unlikely in practice. The file is machine-written, so I'm pretty confident in the json serialization.
add key manager and supporting tests [ committed by @ankona ] [ reviewed by @MattToast @al-rigazzi ]
reorganize code into a telemetry subpackage