Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat manually scheduled cards with no reps as new cards #3727

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

user1823
Copy link
Contributor

@user1823 user1823 commented Jan 15, 2025

Complements the change in #3639, ensuring that scheduler and rescheduling produce the same results.

To be more precise, it complements the removal of the following code in #3639

    if !revlogs_complete {
        revlogs_complete = matches!(
            entries.first(),
            Some(RevlogEntry {
                review_kind: RevlogReviewKind::Manual,
                ..
            }) | Some(RevlogEntry {
                review_kind: RevlogReviewKind::Rescheduled,
                ..
            })
        );
    }

Complements the change in ankitects#3639, ensuring that scheduler and rescheduling produce the same results.
@dae dae merged commit c35237c into ankitects:main Jan 17, 2025
1 check passed
@user1823 user1823 deleted the patch-1 branch January 17, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants