-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix menubar in fullscreen #3710
Conversation
Notes:
|
For more context, please read the original issue #3647 and these comments: #3682 (comment) and #3682 (comment) |
@YukiNagat0 Just looked over your PR, I now understand what the intended functionality of the original code was. I appreciate your effort in trying to explain it to me though! |
Thank you both! I find number 1 a bit confusing, but as you said, that seems to be existing behaviour. If @abdnh is happy with this, good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me.
Fixes: #3647
As alternative to: #3682
Demo:
1.mp4