Ignore reviews before -> Ignore cards reviewed before.ftl #3314
Conversation
Expertium
changed the title
|
@user1823 this is related to my recent pull request in the fsrs4anki repo, where I added a similar warning to the FSRS tutorial |
|
You didn't respond to the concern that I expressed there. Let's continue the discussion in that PR (open-spaced-repetition/fsrs4anki#671). |
ftl/core/deck-config.ftl
Outdated
| This can be useful if you imported someone else's scheduling data, or have changed the way you use the answer buttons. | ||
| If all of your cards have been reviewed before the selected date and you do not plan to add new cards, it's better to use Reset. |
There was a problem hiding this comment.
| If all of your cards have been reviewed before the selected date and you do not plan to add new cards, it's better to use Reset. | |
| If all of your cards have been reviewed before the selected date and you do not plan to add new cards, it's better to reset the cards to new. |
How about that?
There was a problem hiding this comment.
Me and user1823 are still discussing what's the best course of action in this case (all cards reviewed before the selected date, no new cards will be added), but yeah, I don't mind this correction.
There was a problem hiding this comment.
I don't recommend merging this until we figure out what advise we want to give in such cases. See open-spaced-repetition/fsrs4anki#671
|
@dae This feature isn't easily explainable to the users. I think unless this is reworked to made more intuitive this should be in the Advanced section. Or at least at the end of the FSRS section. |
|
No objections from me to moving it to the advanced section. |
|
No objections from me either. |
|
I removed that line with the advice. LMSherlock decided to add a new feature to the Helper add-on that will allow users to replace all instances of "Hard" with "Again" by editing the database. As for users who did not misuse "Hard" AND still wish to use "Ignore reviews before" for whatever reason AND have reviewed all cards before the selected date AND do not plan to introduce new cards, LMSherlock believes that this is a very rare edge case, and we shouldn't be concerned about it. |
|
The number of people who will want to use 'Ignore reviews before' will certainly decrease from that. More reason not to have it in FSRS category. But we will want to still document that (in the tutorial and in the Anki Manual). @dae Can you move this feature to Advanced? |
|
Is this PR ready to merge @Expertium? |
|
Yes, but I'm not sure if it will work, since moving "Ignore cards reviewed before" under Advanced is in a different PR |
|
Oh, so that's why you commented there. I think it should work because in the code we use |
|
@Expertium could you please update CONTRIBUTORS again? Happy to merge this in once the tests pass. |
|
I have exactly 0 clue how checks work and why changing a string somehow causes them to fail. |
|
Thanks! |
First of all, this should make it more clear what this feature does. As it is right now, it's misleading.
Second of all, I added an extra sentence to the tooltip. I recently found a user who encountered an edge case - if ALL cards have been reviewed before the selected date, and NO NEW cards will be introduced, then the optimizer will always have zero data to work with. I added a clarification about that.
And also, I think "reviewed" is better than "introduced", as "introduced" may make the user think that this is about the creation date of the card.