Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacebar causing stutter when editing cards #3150

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

abdnh
Copy link
Collaborator

@abdnh abdnh commented Apr 18, 2024

Some image occlusion event handlers were getting triggered globally in the editor. The keydown handler is registered inside a mousemove handler, which is resulting in countless handlers.

Closes #3131

@abdnh abdnh marked this pull request as draft April 18, 2024 11:26
@abdnh abdnh marked this pull request as ready for review April 18, 2024 12:29
@dae
Copy link
Member

dae commented Apr 19, 2024

Nice - thanks for getting to the bottom of this!

@dae dae merged commit c62e2d8 into ankitects:main Apr 19, 2024
1 check passed
@abdnh abdnh deleted the spacebar-stutter branch April 19, 2024 09:28
dae added a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing the spacebar will stutter when editing cards
2 participants