Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard shortcuts for empty cards and toggle mask on image occlusion #3136

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

escribapetrus
Copy link
Contributor

@escribapetrus escribapetrus commented Apr 11, 2024

Add keyboard shortcuts for empty cards and toggle mask on image occlusion

This change adds two shortcuts:

  • empty cards (Ctrl+Shift+0)
  • toggle mask (Ctrl+Shift+M)

Please let me know if there is a better way to set these shortcuts. 🍄

Closes #3122

@escribapetrus escribapetrus force-pushed the add-keyboard-shortcuts branch 2 times, most recently from 8bb39e1 to 5c56219 Compare April 11, 2024 23:53
…sion

- add shortcut for empty cards
- add shortcut for toggle mask
- set tooltips with shortcuts

use unused shortcut for empty cards
@escribapetrus escribapetrus force-pushed the add-keyboard-shortcuts branch from a36e8b6 to e7aee24 Compare April 12, 2024 00:41
@escribapetrus
Copy link
Contributor Author

It's weird that the email information is breaking the CI. Not only have I made my email public, but also I was already on the CONTRIBUTORS file.

@dae
Copy link
Member

dae commented Apr 12, 2024

When you changed that file, you must have made a change via the GitHub UI, so the listed email is a users.noreply.github.com one. Add a space to your existing entry using your local machine and push the change, and it should fix it.

Please try to find something other than [. It likely will cause problems on some keyboard layouts, where [ is accessed with/without the shift key.

@dae
Copy link
Member

dae commented Apr 12, 2024

(ctrl+alt is another option)

@escribapetrus
Copy link
Contributor Author

@dae Thank you. Fixed the error on CONTRIBUTORS with your tip.

How do you feel about Ctrl+Shift+0 for empty cards?

@dae
Copy link
Member

dae commented Apr 13, 2024

I don't know if that would cause problems. AZERTY keyboard layouts apparently require shift to be held down to access numbers, so I'm not sure ctrl+shift+0 could be distinguished from ctrl+0, which we're already using.

How about ctrl+alt+e?

@dae
Copy link
Member

dae commented Apr 25, 2024

Thank you!

@dae dae merged commit 074becc into ankitects:main Apr 25, 2024
1 check passed
@escribapetrus escribapetrus deleted the add-keyboard-shortcuts branch April 30, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts for: tools -> empty cards…, image occlusion -> toggle mask editor
2 participants