Feature Show Reminder before answer (#3064) #3119
Conversation
|
Regarding your question about merging on the associated issue ticket, please merge the latest main changes into your PR branch. You may need to handle some merge conflicts, as there have been recent changes on the main branch to things like ts paths (eg ../components might become $lib/components, etc) |
|
Ok i'll do theses changes, do i close this PR and do another one then ? @dae |
|
You shouldn't need to close the PR - just (force)push your changes once you've made them. |
|
I believe it's good now. I did |
ftl/core/deck-config.ftl
Outdated
| deck-config-question-action-show-answer = Show Answer | ||
| deck-config-question-action-show-reminder = Show Reminder | ||
| deck-config-question-action = Question action | ||
| deck-config-question-action-tool-tip = The action to perform after the end of the time of the question. Either show answer and auto update or just show a reminder. |
There was a problem hiding this comment.
Let's drop the second sentence, as it simply repeats the dropdown options. Suggested wording:
The action to perform after the question is shown, and time has elapsed.
No need, that will happen when I squash-merge the PR. |
|
while trying to remove core-repo and qt-repo from the PR i did some serious damage and i have strong difficulties going back. I figured that ftl/core-repo and ftl/qt-repo where updtated with the first merge commit. So i tried to revert it, then i updated the file of deck-config but it seems i did not do it properly...@dae |
|
When you get stuck with git, sometimes the easiest solution is to copy the files you have changed, delete the branch you made, and make it again from the current main branch. Then you can copy the modified files in, and check nothing else was changed except the changes you made. |
Added a option in the deck config that allow the user to choose in Autoupdate mode between showing a reminder or revealing the card. Also added my name to the contributors
Loudwig
force-pushed
the
showReminderAfterQuestion
branch
from
fb42da5 to
b148615
Compare
|
It is in deed faster than resolving the git issues that i had :)@dae. |
|
Thank you! |
In the deck config you can choose to show a reminder instead of showing directly the answer at the end of the autoupdate time.
See here the discussion about this issue.