Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rmse in comparing parameters #3087

Conversation

L-M-Sherlock
Copy link
Contributor

The FSRS has update its metric in this PR:

So it's unnecessary to use the universal metric here.

@user1823
Copy link
Contributor

But, is the new RMSE actually better than the universal metric for comparing the two sets of parameters?

@L-M-Sherlock
Copy link
Contributor Author

The new RMSE is less likely to cheat and still easy to understand:
https://github.com/open-spaced-repetition/fsrs4anki/wiki/The-Metric

And keeping the consistency between evaluation and comparing parameters could reduce the confusion of users.

@Expertium
Copy link
Contributor

But, is the new RMSE actually better than the universal metric for comparing the two sets of parameters?

The way I see it, both the new RMSE and UM are uncheatable, so we could use either. But there are two reasons to use RMSE:

  1. It's more intuitive
  2. It's confusing if we use different metrics "externally" (what is shown to the user) and "internally" (how two sets of parameters are compared)

Also, I had the following "bug", which is likely due to UM:

  1. Optimize parameters
  2. Evaluate parameters
  3. Reset them to default
  4. Optimize them again and obtain new parameters
  5. Evaluate the new parameters

New parameters after the reset result in lower RMSE and lower log loss.

@user1823
Copy link
Contributor

Ok, so let's use the new RMSE

@dae
Copy link
Member

dae commented Mar 24, 2024

Thanks guys.

@dae dae merged commit 74a603e into ankitects:main Mar 24, 2024
1 check passed
@L-M-Sherlock L-M-Sherlock deleted the use-the-same-metric-in-comparing-parameters-and-evaluation branch March 24, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants