Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message if current FSRS parameters are optimal #3014

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

abdnh
Copy link
Collaborator

@abdnh abdnh commented Feb 19, 2024

@abdnh abdnh force-pushed the fsrs-optimal-params-message branch from 48f2512 to 0846852 Compare February 20, 2024 11:16
@abdnh abdnh force-pushed the fsrs-optimal-params-message branch from 0846852 to bbcb028 Compare February 20, 2024 11:16
@dae
Copy link
Member

dae commented Feb 21, 2024

One minor bug: when the parameters are empty/the defaults, hitting optimize shows the message even though it filled in the data.

Do you think maybe the tooltip would be better done as an alert()? It might make it a bit clearer that something has popped up, as it can be a bit tricky to spot if the user has a bunch of other warnings already shown on that screen.

@abdnh
Copy link
Collaborator Author

abdnh commented Feb 21, 2024

Do you think maybe the tooltip would be better done as an alert()? It might make it a bit clearer that something has popped up, as it can be a bit tricky to spot if the user has a bunch of other warnings already shown on that screen.

I used that at first but thought the message doesn't need to be that conspicuous. But since most people voted for displaying a message, maybe less people will complain about alert().

@dae
Copy link
Member

dae commented Feb 22, 2024

Thanks Abdo!

@dae dae merged commit 00c67fc into ankitects:main Feb 22, 2024
1 check passed
@abdnh abdnh deleted the fsrs-optimal-params-message branch February 22, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants