Remember endpoint we authenticated against in returned SyncAuth #2864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for Anki. I have 1.1mil reviews going back 14 years. :)
I'm working on reusing the Rust backend in a project, and I hit a bug related to using a custom sync server.
This pair of method calls authenticates against
http://custom-sync-endpoint
, but then when it checks the sync status, it unexpectedly queries the public ankiweb. This is because theanki_proto::sync::SyncAuth
returned insync_login_inner()
hardcodesendpoint: None
.With this PR, the
SyncAuth
is populated correctly so thatsync_status
method correctly querieshttp://custom-sync-endpoint
instead of ankiweb. (And if the user isn't using a custom sync server, we still preserve theendpoint: None
behavior.)This bug doesn't affect desktop Anki because the Python client stashes the
hkey
out of theSyncAuth
return value here in sync_login, and then constructs a newSyncAuth
from scratch later in sync_auth.